----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/591/#review1097 -----------------------------------------------------------
src/arch/x86/linux/linux.hh <http://reviews.m5sim.org/r/591/#comment1463> These RUSAGE and RLIMIT constants come from generic header files in Linux, not one specific to X86. If they aren't there already, they should be in a base class, not an x86 (or especially a 64 bit x86) subclass. src/arch/x86/linux/linux.hh <http://reviews.m5sim.org/r/591/#comment1462> This constant is wrong according to http://lxr.linux.no/linux+*/include/asm-generic/resource.h#L26. This should be NPROC. Similarly 7 is NOFILE, 8 is MEMLOCK, and 9 is AS (VMEM doesn't seem to exist). There are some others which have been left out. src/arch/x86/linux/linux.hh <http://reviews.m5sim.org/r/591/#comment1464> The indentation here is off. src/arch/x86/linux/linux.hh <http://reviews.m5sim.org/r/591/#comment1465> These constants also need to be fixed, or removed if the 64 bit versions get promoted to a base class. - Gabe On 2011-03-17 16:06:30, Lisa Hsu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/591/ > ----------------------------------------------------------- > > (Updated 2011-03-17 16:06:30) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > X86: rlimit: Another patch from Vince Weaver > > > Diffs > ----- > > src/arch/x86/linux/linux.hh 2e269d6fb3e6 > src/arch/x86/linux/syscalls.cc 2e269d6fb3e6 > > Diff: http://reviews.m5sim.org/r/591/diff > > > Testing > ------- > > > Thanks, > > Lisa > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
