----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/635/#review1104 -----------------------------------------------------------
Overall, this seems pretty straightforward. However I'm confused by the double curTick concerns. Specific comments below. src/mem/ruby/system/Sequencer.cc <http://reviews.m5sim.org/r/635/#comment1473> If we are going to replace the cycle count with curTick(), then we should increase the width of that first field well beyond 7. Something like 15 makes sense to me. What do you think? Also I'm confused by Nilay's concern about printing out the curTick twice. DPRINTFR doesn't print out the curTick by default, correct? Therefore the current tick will only be printed once. src/mem/ruby/system/Sequencer.cc <http://reviews.m5sim.org/r/635/#comment1474> Same thing here. Increase first field well beyond 7. src/mem/slicc/symbols/StateMachine.py <http://reviews.m5sim.org/r/635/#comment1475> beyond 7 src/mem/slicc/symbols/StateMachine.py <http://reviews.m5sim.org/r/635/#comment1476> beyond 7 src/mem/slicc/symbols/StateMachine.py <http://reviews.m5sim.org/r/635/#comment1477> beyond 7 - Brad On 2011-04-05 11:19:26, Korey Sewell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/635/ > ----------------------------------------------------------- > > (Updated 2011-04-05 11:19:26) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ruby: dbg: use system ticks instead of cycles > It's easier to debug simulations (find the exact point to rerun a trace) when > the output is in > the system ticks instead of the Ruby cycle time > > > Diffs > ----- > > src/mem/ruby/buffers/MessageBuffer.cc 54a65799e4c1 > src/mem/ruby/network/simple/PerfectSwitch.cc 54a65799e4c1 > src/mem/ruby/system/Sequencer.cc 54a65799e4c1 > src/mem/slicc/symbols/StateMachine.py 54a65799e4c1 > src/mem/slicc/symbols/Type.py 54a65799e4c1 > > Diff: http://reviews.m5sim.org/r/635/diff > > > Testing > ------- > > > Thanks, > > Korey > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
