----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/637/#review1107 -----------------------------------------------------------
Hi Somayeh, It doesn't appear that your patch applies cleanly to the current tree because all I see is a javascript error. Regardless, I don't think we should add something to the repo to make those temporary patches work. I know I suggested sending a patch out for review earlier, but I was under the wrong impression that the compile issue was not a line that my patch added. My fault. Instead of adding code to the main repo to make those patches work, I suggest change the patches directly. - Brad On 2011-04-11 12:06:10, Somayeh Sardashti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/637/ > ----------------------------------------------------------- > > (Updated 2011-04-11 12:06:10) > > > Review request for Default and Brad Beckmann. > > > Summary > ------- > > Cache warmup: fixed compile errors in Brad's cache warmup patches > > > Diffs > ----- > > src/mem/ruby/network/simple/Topology.hh 955a58f51a6d > src/mem/ruby/recorder/Tracer.hh 955a58f51a6d > src/mem/ruby/system/CacheMemory.hh 955a58f51a6d > > Diff: http://reviews.m5sim.org/r/637/diff > > > Testing > ------- > > > Thanks, > > Somayeh > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
