----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/631/#review1110 -----------------------------------------------------------
At a high level there are really two changes here, some renovation of the output directory class, and then the actual VNC stuff, and they may be of interest to different people. I'd be a lot more comfortable with the output directory part if Nate was ok with it, for instance, but he might not even know those files are involved from the change description. src/base/bitmap.hh <http://reviews.m5sim.org/r/631/#comment1494> This will work, I think, but why not just keep a flag around that you set when somebody changes some bytes in the buffer? I don't think there's a way for them to do that that you wouldn't see. hashing the whole image over and over is probably pretty expensive. src/base/bitmap.cc <http://reviews.m5sim.org/r/631/#comment1493> memcpy and these casts make me nervous. I think the casts are probably unnecessary since memcpy takes void*s and I'm pretty sure any pointer can be implicitly cast into a void *. - Gabe On 2011-04-10 16:50:13, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/631/ > ----------------------------------------------------------- > > (Updated 2011-04-10 16:50:13) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > VNC: Add support for capturing frame buffer to file each time it is changed. > > When a change in the frame buffer from the VNC server is detected, the new > frame is stored out to the m5out/frames_*/ directory. Specifiy the flag > "--frame-capture" when running configs/example/fs.py to enable this behavior. > > > Diffs > ----- > > configs/example/fs.py 02cb69e5cfeb > src/base/bitmap.hh 02cb69e5cfeb > src/base/bitmap.cc 02cb69e5cfeb > src/base/output.hh 02cb69e5cfeb > src/base/output.cc 02cb69e5cfeb > src/base/vnc/VncServer.py 02cb69e5cfeb > src/base/vnc/convert.hh 02cb69e5cfeb > src/base/vnc/convert.cc 02cb69e5cfeb > src/base/vnc/vncserver.hh 02cb69e5cfeb > src/base/vnc/vncserver.cc 02cb69e5cfeb > > Diff: http://reviews.m5sim.org/r/631/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
