----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/661/#review1161 -----------------------------------------------------------
src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.py <http://reviews.m5sim.org/r/661/#comment1601> In garnet, the link width is actually equal to flit size (i.e. the entire flit is injected into the link). [bigger packets such as data are thereby broken into multiple flits]. So not sure if having both a "bandwidth_factor" and a "flit_size" parameter inside BaseGarnetNetwork.py will work. Perhaps we should set flit_size equal to bandwidth_factor there? "link_bandwidth" is a clearer term but I understand that is not true for simple network where the endpoint bandwidth comes into play... - Tushar On 2011-04-27 10:38:47, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/661/ > ----------------------------------------------------------- > > (Updated 2011-04-27 10:38:47) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > network: generalized bw for basic links > > Generalized the specification of bw for basic links. This value is then > translated to the specific value used by the simple and Garnet networks. > > > Diffs > ----- > > configs/ruby/Ruby.py b02bca5aed04 > src/mem/ruby/network/BasicLink.hh PRE-CREATION > src/mem/ruby/network/BasicLink.cc PRE-CREATION > src/mem/ruby/network/BasicLink.py PRE-CREATION > src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.py PRE-CREATION > src/mem/ruby/network/simple/SConscript b02bca5aed04 > src/mem/ruby/network/simple/SimpleLink.hh PRE-CREATION > src/mem/ruby/network/simple/SimpleLink.cc PRE-CREATION > src/mem/ruby/network/simple/SimpleLink.py PRE-CREATION > src/mem/ruby/network/simple/SimpleNetwork.cc b02bca5aed04 > > Diff: http://reviews.m5sim.org/r/661/diff > > > Testing > ------- > > > Thanks, > > Brad > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
