----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/660/#review1166 -----------------------------------------------------------
Ship it! This looks good to me, though it does appear to be a combination of a bug fix and the added sim_cycle parameter. However, I understand why they are related so I don't think it is necessary to split them. - Brad On 2011-04-25 16:18:04, Tushar Krishna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/660/ > ----------------------------------------------------------- > > (Updated 2011-04-25 16:18:04) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, Nathan > Binkert, and Brad Beckmann. > > > Summary > ------- > > NetworkTest: added sim_cycles parameter to the network tester. > > The network tester terminates after injecting for sim_cycles > (default=1000), instead of having to explicitly pass --maxtick from the > command line as before. If fixed_pkts is enabled, the tester stops > scheduling itself after injecting maxpackets number of packets. > The tester also works with zero command line arguments now. > > > Diffs > ----- > > configs/example/ruby_network_test.py de679a068dd8 > src/cpu/testers/networktest/NetworkTest.py de679a068dd8 > src/cpu/testers/networktest/networktest.hh de679a068dd8 > src/cpu/testers/networktest/networktest.cc de679a068dd8 > > Diff: http://reviews.m5sim.org/r/660/diff > > > Testing > ------- > > > Thanks, > > Tushar > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
