----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/667/#review1193 -----------------------------------------------------------
Ship it! Overall, this looks good to me. One thing you may consider is giving the wrap-around links a higher latency. src/mem/ruby/network/topologies/Torus.py <http://reviews.m5sim.org/r/667/#comment1648> Should we give the wrap-around links a higher latency? src/mem/ruby/network/topologies/Torus.py <http://reviews.m5sim.org/r/667/#comment1649> Same here, higher latency? - Brad On 2011-04-29 15:58:51, Tushar Krishna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/667/ > ----------------------------------------------------------- > > (Updated 2011-04-29 15:58:51) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, Nathan > Binkert, and Brad Beckmann. > > > Summary > ------- > > network: added Torus and Pt2Pt topologies > > > Diffs > ----- > > src/mem/ruby/network/topologies/Pt2Pt.py PRE-CREATION > src/mem/ruby/network/topologies/SConscript 7939dd0c4ff2 > src/mem/ruby/network/topologies/Torus.py PRE-CREATION > > Diff: http://reviews.m5sim.org/r/667/diff > > > Testing > ------- > > > Thanks, > > Tushar > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
