----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/676/#review1204 -----------------------------------------------------------
Ship it! I'm surprised this wasn't fixed earlier. Thanks for do this Korey! - Brad On 2011-05-03 22:24:46, Korey Sewell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/676/ > ----------------------------------------------------------- > > (Updated 2011-05-03 22:24:46) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ruby: use RubyMemory flag & remove setDebug() functionality > The RubyMemory flag wasnt used in the code, creating large gaps in trace > output. Replace cprintfs w/dprintfs > using RubyMemory in memory controller. DPRINTF also deprecate the usage of > the setDebug() pure virtual > function in the AbstractMemoryOrCache Class as well the m_debug/cprintf > functions in MemoryControl.hh/cc > > > Diffs > ----- > > src/mem/ruby/system/AbstractMemOrCache.hh 3f49ed206f46 > src/mem/ruby/system/MemoryControl.hh 3f49ed206f46 > src/mem/ruby/system/MemoryControl.cc 3f49ed206f46 > > Diff: http://reviews.m5sim.org/r/676/diff > > > Testing > ------- > > > Thanks, > > Korey > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
