On 12 May 2011, at 04:24, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/690/#review1226 > ----------------------------------------------------------- > > > I guess I should have said something, but there are several more diffs to > come down the road. I just wanted to get some out of the way now. By the > end, there will be no output code in C++ at all. > > > src/python/m5/stats/__init__.py > <http://reviews.m5sim.org/r/690/#comment1691> > > If you have a periodic dumping of stats because of an event and you get a > dumpstats from an m5op or from kill -USR1, you don't want to dump twice in > the same cycle because stuff just doesn't work well. >
Where in the code is the signal from "kill -USR1" handled to dump stats? > - Nathan > > > On 2011-05-10 06:08:36, Nathan Binkert wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviews.m5sim.org/r/690/ >> ----------------------------------------------------------- >> >> (Updated 2011-05-10 06:08:36) >> >> >> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and >> Nathan Binkert. >> >> >> Summary >> ------- >> >> stats: move code that loops over all stats into python >> >> >> Diffs >> ----- >> >> src/base/SConscript 44f8c2507d85 >> src/base/statistics.hh 44f8c2507d85 >> src/base/statistics.cc 44f8c2507d85 >> src/base/stats/info.hh 44f8c2507d85 >> src/base/stats/mysql.hh 44f8c2507d85 >> src/base/stats/mysql.cc 44f8c2507d85 >> src/base/stats/output.hh 44f8c2507d85 >> src/base/stats/output.cc 44f8c2507d85 >> src/base/stats/text.hh 44f8c2507d85 >> src/base/stats/text.cc 44f8c2507d85 >> src/base/stats/visit.hh 44f8c2507d85 >> src/base/stats/visit.cc 44f8c2507d85 >> src/python/m5/simulate.py 44f8c2507d85 >> src/python/m5/stats/__init__.py PRE-CREATION >> src/python/swig/stats.i 44f8c2507d85 >> >> Diff: http://reviews.m5sim.org/r/690/diff >> >> >> Testing >> ------- >> >> quick regressions pass (though most recently run with review 689 and 691) >> >> >> Thanks, >> >> Nathan >> >> > > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
