Hello, John, A few questions:- Did you add the respective SHIPRP class in ReplacementPolicies.py?- Are you making sure the namespace is properly applied in the Python declaration (Something like cxx_class='ReplacementPolicy::SHiP')? - When you downloaded the patches for DRRIP, did you cherry-pick? If not, then you have probably also applied the patch https://gem5-review.googlesource.com/c/public/gem5/+/35938 , in which case you need to declare the constructor as "const Params &p".
Bonus: Long ago I have also implemented SHiP-PC and SHiP-Mem. I *think* I was confident of their implementation, but I have to double-check it later. It would be great if you could take a look and give some feedback: https://gem5-review.googlesource.com/c/public/gem5/+/38118 Regards,Daniel Em sábado, 28 de novembro de 2020 00:11:28 GMT+1, John H via gem5-users <[email protected]> escreveu: Hello, I tried creating a separate .cc and .hh file for implementing a new replacement policy and added it to Scons within replacement policies. However, when i run gem5 build, I get the following error message build/X86/mem/cache/replacement_policies/ship_rp.cc:13:22: error: 'Params' does not name a type SHIPRP::SHIPRP(const Params *p) ^ build/X86/mem/cache/replacement_policies/ship_rp.cc:13:30: error: ISO C++ forbids declaration of 'p' with no type [-fpermissive] SHIPRP::SHIPRP(const Params *p) ^ build/X86/mem/cache/replacement_policies/ship_rp.cc:13:31: error: invalid use of incomplete type 'class SHIPRP' SHIPRP::SHIPRP(const Params *p) ^ In file included from build/X86/mem/cache/replacement_policies/ship_rp.cc:8:0: build/X86/params/SHIPRP.hh:4:7: error: forward declaration of 'class SHIPRP' class SHIPRP; ^ build/X86/mem/cache/replacement_policies/ship_rp.cc:16:1: error: expected unqualified-id before '{' token { ^ scons: *** [build/X86/mem/cache/replacement_policies/ship_rp.o] Error 1 scons: building terminated because of errors. Can you please guide me on how to fix this? Thanks, John _______________________________________________ gem5-users mailing list -- [email protected] To unsubscribe send an email to [email protected] %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
_______________________________________________ gem5-users mailing list -- [email protected] To unsubscribe send an email to [email protected] %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
