On Fri, 3 Oct 2025 at 11:33, Niall Pemberton <[email protected]> wrote: > > I'm not familiar with the docker repo. I understand its used to test > the Attic banner & CSP, but I've never tried to use/run it.
Yes. It takes a little effort to set it up if you haven't used Docker before, but it makes checking the banner and CSP updates very much easier. For example, the hostname of the website under test has to be passed in to the Docker container. If it turns out that the default banner filter does not work, it is easy to check if one of the existing overrides works - just pass in the name. The link to the Attic website in the banner will be wrong, but one can quickly check all the existing overrides to see if one displays the banner correctly. Much easier than actually editing the HTML and then working out how to do the override, only to find it already exists ... > I can understand merging it to simplify down to having one repo but it > also feels like a pollution of the website generation. Does the lua > script need to be in the Attic repo or could it move to attic-docker? Yes, because the Lua script needs to be present in the attic checkout on the TLP server host. It's invoked if the TLP server detects the relevant marker directory. > That way we would have a clear separation between the banner script > and website generation? > > I don't have strong feelings about this though - so if you and Herve > still want to go ahead and merge then I won't oppose it. > > Regards > > Niall > > On Thu, 2 Oct 2025 at 16:01, sebb <[email protected]> wrote: > > > > The attic-docker Git repo was created before the main attic Git repo was > > set up. > > > > I'm not sure it makes sense to have a separate repo now, especially > > since the Docker build needs a copy of the attic_filter.lua script > > which is maintained in the main attic repo. > > > > Not many files are involved, so I think it would make sense to merge > > attic-docker into attic, and then drop attic-docker. > > > > Thoughts? > > > > Sebb
