On 01/06/2009, Gurkan Erdogdu <cgurkanerdo...@gmail.com> wrote: > JSF Facelet license is Apache License, Version > 2.0.<http://www.apache.org/licenses/LICENSE-2.0>
Ah, I found it eventually on http://facelets.dev.java.net/. [BTW, when I searched for jsf-facelets-1.1.14.jar I found it in various repos; one of them - http://repository.jboss.com/maven2/com/sun/facelets/jsf-facelets/1.1.14/jsf-facelets-1.1.14.pom - said it was licensed under CDDL 1.1. Shows that one needs to check the License as published by the owner.] > Is it still required to mention it in the N&L? Yes, I think you need to mention http://facelets.dev.java.net/ > So, the remaining blocker issues is > > * Notice file content in the jars? > * MANIFEST.mf content? (What will be the content of this?) Instead of: Implementation-Title: OpenWebBeans :: WebBeans-API Implementation-Vendor: The Apache OpenWebBeans development community ... Specification-Title: OpenWebBeans :: WebBeans-API Specification-Vendor: The Apache OpenWebBeans development community you need to put Implementation-Title: Apache OpenWebBeans :: WebBeans-API Implementation-Vendor: The Apache Software Foundation ... Specification-Title: Apache OpenWebBeans :: WebBeans-API Specification-Vendor: The Apache Software Foundation > Is it OK? I will correct this and create new release tag (rc3) in the > evening. I suggest you start a new e-mail for the vote; please include the SVN tag revision. > Thanks sebb; > > -- Gurkan > > > > 2009/6/1 sebb <seb...@gmail.com> > > > I get the following for "svn info" > > > > URL: > > > http://svn.apache.org/repos/asf/incubator/openwebbeans/tags/openwebbeans-1.0.0-incubating-M2 > > ... > > Last Changed Rev: 780477 > > ... > > > > So we agree. > > > > == > > > > The top-level NOTICE and LICENSE files are fine now. > > > > The licenses/ directory should now be removed from SVN and the > > archives (but that's not a blocker). > > > > Unfortunately, the NOTICE files in the jars are incorrect. > > > > For example openwebbeans-api-1.0.0-incubating-M2.jar/NOTICE: > > > > ------------------------ > > OpenWebBeans :: WebBeans-API > > Copyright 2008-2009 The Apache OpenWebBeans development community > > > > This product includes software developed at > > The Apache Software Foundation (http://www.apache.org/). > > ------------------------ > > > > This should be > > > > ------------------------ > > Apache OpenWebBeans :: WebBeans-API > > Copyright 2008-2009 The Apache Software Foundation > > > > This product includes software developed at > > The Apache Software Foundation (http://www.apache.org/). > > ------------------------ > > > > Similarly for the Implementation and Specification, Title and Vendor > > entries in the Manifest. > > > > I'm afraid these are release blockers; it's vital that the correct > > names are used in NOTICE files. > > > > The files guess-1.0.0-incubating-M2.war and > > reservation-1.0.0-incubating-M2.war both include a copy of > > jsf-facelets-1.1.14.jar, however this does not appear to be mentioned > > in the NOTICE or LICENSE files in the WAR or at the top-level. I could > > not find the jar or its LICENSE on the Sun web-site, so this needs to > > be double-checked. > > > > The N&L files in the WAR files need to be fixed before release. > > > > The POM in the source archives does not agree with the POM in SVN, as > > there is a minor difference in the following line: > > > > ZIP: <siteId>/OWB/1.0.0-incubating-M2-rc2/distribution</siteId> > > SVN: <siteId>/OWB/1.0.0-incubating-M2/distribution</siteId> > > > > I don't know what the significance of this is. > > > > There are still some missing SVN eol-style properties in SVN: > > > > svn ps svn:eol-style native webbeans-api/src/site/site.xml > > svn ps svn:eol-style native webbeans-api/src/site/apt/index.apt > > svn ps svn:eol-style native webbeans-impl/src/it/settings.xml > > svn ps svn:eol-style native webbeans-impl/src/it/properties/pom.xml > > svn ps svn:eol-style native > > > > > webbeans-impl/src/it/properties/src/test/java/org/apache/webbeans/test/spi/configuration/ConfigurationTest.java > > svn ps svn:eol-style native > > > > > webbeans-impl/src/it/properties/src/test/resources/META-INF/openwebbeans/openwebbeans.properties > > svn ps svn:eol-style native > > > > > webbeans-impl/src/main/java/org/apache/webbeans/config/OpenWebBeansConfiguration.java > > svn ps svn:eol-style native > > > > > webbeans-impl/src/main/java/org/apache/webbeans/container/ChildActivityManager.java > > svn ps svn:eol-style native > > > > > webbeans-impl/src/main/java/org/apache/webbeans/plugins/OpenWebBeansPlugin.java > > svn ps svn:eol-style native > > webbeans-impl/src/main/java/org/apache/webbeans/plugins/PluginLoader.java > > svn ps svn:eol-style native > > webbeans-impl/src/main/java/org/apache/webbeans/spi/JNDIService.java > > svn ps svn:eol-style native > > webbeans-impl/src/main/java/org/apache/webbeans/spi/ServiceLoader.java > > svn ps svn:eol-style native > > webbeans-impl/src/main/java/org/apache/webbeans/spi/TransactionService.java > > svn ps svn:eol-style native > > > > > webbeans-impl/src/main/java/org/apache/webbeans/spi/se/JNDIServiceStaticImpl.java > > svn ps svn:eol-style native > > > > > webbeans-impl/src/main/java/org/apache/webbeans/spi/se/TransactionServiceNonJTA.java > > svn ps svn:eol-style native > > > > > webbeans-impl/src/main/resources/META-INF/openwebbeans/openwebbeans-default.properties > > svn ps svn:eol-style native webbeans-impl/src/site/site.xml > > svn ps svn:eol-style native webbeans-impl/src/site/apt/index.apt > > svn ps svn:eol-style native > > webbeans-impl/src/test/resources/META-INF/persistence.xml > > > > And there are some files marked as executable which should not be: > > > > svn pd svn:executable samples/guess/src/main/resources/log4j.properties > > svn pd svn:executable samples/guess/src/main/resources/META-INF/beans.xml > > svn pd svn:executable samples/guess/src/main/webapp/WEB-INF/beans.xml > > svn pd svn:executable > > samples/reservation/src/main/resources/log4j.properties > > svn pd svn:executable > > samples/reservation/src/main/resources/META-INF/beans.xml > > svn pd svn:executable samples/reservation/src/main/webapp/WEB-INF/beans.xml > > svn pd svn:executable > > webbeans-api/src/main/java/javax/context/ApplicationScoped.java > > svn pd svn:executable > > webbeans-api/src/main/java/javax/context/ContextNotActiveException.java > > svn pd svn:executable > > webbeans-api/src/main/java/javax/context/ConversationScoped.java > > svn pd svn:executable > > webbeans-api/src/main/java/javax/context/Dependent.java > > svn pd svn:executable > > webbeans-api/src/main/java/javax/inject/BindingType.java > > svn pd svn:executable webbeans-api/src/main/java/javax/inject/Disposes.java > > svn pd svn:executable webbeans-geronimo/src/test/resources/log4j.properties > > svn pd svn:executable > > webbeans-impl/src/main/java/org/apache/webbeans/WebBeansConstants.java > > svn pd svn:executable > > > > > webbeans-impl/src/main/java/org/apache/webbeans/exception/WebBeansException.java > > svn pd svn:executable webbeans-impl/src/main/resources/log4j.properties > > svn pd svn:executable webbeans-tck/src/test/resources/log4j.properties > > > > The SVN problems are not blockers, but it would help if they were > > fixed before any new tags are made. > > > > On 01/06/2009, Gurkan Erdogdu <cgurkanerdo...@gmail.com> wrote: > > > Also this is the commit command > > > > > > Revision *780477*< > > > http://svn.apache.org/viewvc?view=rev&sortby=log&sortdir=down&revision=780477 > > >- > > > Directory > > > Listing< > > > http://svn.apache.org/viewvc/incubator/openwebbeans/tags/openwebbeans-1.0.0-incubating-M2/?sortby=log&sortdir=down&pathrev=780477 > > > > > > Modified *Sun May 31 17:28:57 2009 UTC* (12 hours, 13 minutes ago) by * > > > gerdogdu* > > > Copied from: *incubator/openwebbeans/trunk*< > > > http://svn.apache.org/viewvc/incubator/openwebbeans/trunk?view=log&sortby=log&sortdir=down&pathrev=780474 > > >revision > > > 780474 > > > > > > [maven-release-plugin] copy for tag openwebbeans-1.0.0-incubating-M2 > > > > > > > > > > > > 2009/6/1 Gurkan Erdogdu <gurkanerdo...@yahoo.com> > > > > > > > > > > Sorry I do not understand what you mean. I am also not a svn expert. > > > > > > > > I am looking at > > > > > > > http://svn.apache.org/viewvc/incubator/openwebbeans/tags/openwebbeans-1.0.0-incubating-M2/?pathrev=780504 > > > > . > > > > > > > > When I opened URL, it shows the > > > > > > > > Directory revision: 780477 (of 780556) > > > > Sticky revision : 780504 > > > > > > > > I think this helps; > > > > > > > > But last M2 location is undertags/openwebbeans-1.0.0-incubating-M2. > > This is > > > > the last revision. Please VOTE on this. > > > > > > > > Thanks; > > > > > > > > --Gurkan > > > > > > > > > > > > > > > > > > > > ________________________________ > > > > From: sebb <seb...@gmail.com> > > > > To: general@incubator.apache.org > > > > Sent: Monday, June 1, 2009 1:11:56 AM > > > > Subject: Re: [VOTE] Release OpenWebBeans 1.0.0-incubating-M2(Second > > Try) > > > > > > > > On 31/05/2009, Gurkan Erdogdu <gurkanerdo...@yahoo.com> wrote: > > > > > >>>Please provide the SVN revision which applies to the current tag. > > > > > > > > > > >>Current Tag Revision is 780496 > > > > > > > > > > > > > > > Sorry I have given wrong revision. Current M2 tag is created based > > on > > > > version "At revision 780504" > > > > > > > > Neither of those agree with what I have just downloaded. > > > > > > > > What is the "Last Changed Rev:" ? > > > > > > > > That should be the same as revision in the SVN commit message. > > > > > > > > > -- Gurkan > > > > > > > > > > > > > > > > > > > > > > > > > ________________________________ > > > > > From: Gurkan Erdogdu <gurkanerdo...@yahoo.com> > > > > > > > > > > To: general@incubator.apache.org > > > > > > > > > > Sent: Sunday, May 31, 2009 10:25:14 PM > > > > > > > > > > Subject: Re: [VOTE] Release OpenWebBeans 1.0.0-incubating-M2(Second > > Try) > > > > > > > > > > >>>Please provide the SVN revision which applies to the current > > tag. > > > > > > > > > > Current Tag Revision is 780496 > > > > > > > > > > Thanks; > > > > > > > > > > > > > > > > > > > > > > > > > ________________________________ > > > > > From: sebb <seb...@gmail.com> > > > > > To: general@incubator.apache.org > > > > > Sent: Sunday, May 31, 2009 10:06:00 PM > > > > > Subject: Re: [VOTE] Release OpenWebBeans 1.0.0-incubating-M2(Second > > Try) > > > > > > > > > > On 31/05/2009, Gurkan Erdogdu <gurkanerdo...@yahoo.com> wrote: > > > > > > Hi; > > > > > > > > > > > > I have corrected the errors. New artifacts can be found at the > > below > > > > URLs. > > > > > > > > > > > > Plugins repository > > > > > > -------------------------- > > > > > > > > > > > > > > > > http://people.apache.org/~gerdogdu/staging-repo/OWB/1.0.0-incubating-M2-rc2/plugins/org/apache/openwebbeans<http://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-incubating-M2-rc2/plugins/org/apache/openwebbeans> > > < > > > http://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-incubating-M2-rc2/plugins/org/apache/openwebbeans > > > > > > > > > > > > > > > Distribution content > > > > > > ---------------------------- > > > > > > > > > > > > > http://people.apache.org/~gerdogdu/staging-repo/OWB/1.0.0-incubating-M2-rc2/distribution/org/apache/openwebbeans/apache-openwebbeans-distribution/1.0.0-incubating-M2/<http://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-incubating-M2-rc2/distribution/org/apache/openwebbeans/apache-openwebbeans-distribution/1.0.0-incubating-M2/> > > < > > > http://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-incubating-M2-rc2/distribution/org/apache/openwebbeans/apache-openwebbeans-distribution/1.0.0-incubating-M2/ > > > > > > > > > > > > > > > > > > SVN New Tag > > > > > > ---------------------------- > > > > > > > > > > > > > http://svn.apache.org/repos/asf/incubator/openwebbeans/tags/openwebbeans-1.0.0-incubating-M2/ > > > > > > > > > > You appear to have re-used the same tag name. > > > > > Tags are normally supposed to be immutable, otherwise there is no > > > > > means of knowing what files they relate to. > > > > > > > > > > Please provide the SVN revision which applies to the current tag. > > > > > [The combination of the revision and the tag allows the files to be > > > > > uniquely identified, thus getting round the problem of the mutable > > > > > tag] > > > > > > > > > > > thanks; > > > > > > > > > > > > --Gurkan > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ________________________________ > > > > > > From: sebb <seb...@gmail.com> > > > > > > To: general@incubator.apache.org > > > > > > Sent: Sunday, May 31, 2009 2:38:07 PM > > > > > > Subject: Re: [VOTE] Release OpenWebBeans 1.0.0-incubating-M2 > > > > > > > > > > > > On 31/05/2009, Gurkan Erdogdu <gurkanerdo...@yahoo.com> wrote: > > > > > > > > > > > > > > > > > > > > > >>The .asc.md5 and .asc.sha1 hashes should be deleted as they > > serve > > > > no > > > > > > > purpose. > > > > > > > > > > > > > > >>The POM files in the source archives have the wrong version; > > they > > > > are > > > > > > > using > > > > > > > >>1.0.0-incubating-SNAPSHOT whereas they should have > > > > > > > >>1.0.0-incubating-M2 > > > > > > > > > > > > > > >>This is a release blocker. Looks like the artifacts were > > built > > > > from > > > > > > > >>the wrong SVN checkout. > > > > > > > > > > > > > > OK, I will correct those. > > > > > > > > > > > > > > >>>There are some major problems with the NOTICE and LICENSE > > files. > > > > > > > > > > > > > > When we created these file, we got help from our mentors. So > > we > > > > corrected > > > > > > > those files in the M1 release repeatedly. If you look at the > > for > > > > example, > > > > > > > Geronimo NOTICE file, it really like to OWB. I attached > > Geronimo > > > > NOTICE > > > > > > > file for example. > > > > > > > > > > > > I'm afraid that NOTICE file is wrong as well. > > > > > > > > > > > > See: > > > > > > > > > > > > http://www.apache.org/dev/release.html#notice-content > > > > > > and > > > > > > http://apache.org/legal/src-headers.html#notice > > > > > > http://apache.org/legal/src-headers.html#faq-examplenotice > > > > > > > > > > > > > We have included "*licenses*" folder to hold third party > > license > > > > texts to > > > > > > > ease reading of the third party licenses. Is it really > > necessary to > > > > put all > > > > > > > of these text lines into the LICENCE text? Is it really block > > > > release? > > > > > > > > > > > > > > > > > > > Yes, the user must be able to find all the licences by checking > > the > > > > > > LICENSE file. > > > > > > > > > > > > See: > > > > > > > > > > > > > > > > > > > http://www.apache.org/dev/release.html#distributing-code-under-several-licenses > > > > > > > > > > > > > Thanks; > > > > > > > > > > > > > > --- Gurkan > > > > > > > > > > > > > > > > > > > > > ________________________________ > > > > > > > From: sebb <seb...@gmail.com> > > > > > > > To: general@incubator.apache.org > > > > > > > Sent: Saturday, May 30, 2009 2:36:12 PM > > > > > > > Subject: Re: [VOTE] Release OpenWebBeans 1.0.0-incubating-M2 > > > > > > > > > > > > > > On 26/05/2009, Gurkan Erdogdu <gurkanerdo...@yahoo.com> > > wrote: > > > > > > > > Hi; > > > > > > > > > > > > > > > > OpenWebBeans will be an ASL-licensed implementation of the > > Web > > > > Beans > > > > > > > Specification which is defined as JSR-299. > > > > > > > > > > > > > > > > Proposed released artifacts are: > > > > > > > > > > > > > > > > Plugins repository > > > > > > > > -------------------------- > > > > > > > > > > > > > > > > > > > > > > > > > http://people.apache.org/~gerdogdu/staging-repo/OWB/1.0.0-incubating-M2/plugins/org/apache/openwebbeans<http://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-incubating-M2/plugins/org/apache/openwebbeans> > > < > > > http://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-incubating-M2/plugins/org/apache/openwebbeans > > > > > > > > > > > > > > > > > > > > I've not checked these. > > > > > > > > > > > > > > > Distribution content > > > > > > > > ---------------------------- > > > > > > > > > > > > > > > > > > > > > > > > > http://people.apache.org/~gerdogdu/staging-repo/OWB/1.0.0-incubating-M2/distribution/org/apache/openwebbeans/apache-openwebbeans-distribution/1.0.0-incubating-M2/<http://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-incubating-M2/distribution/org/apache/openwebbeans/apache-openwebbeans-distribution/1.0.0-incubating-M2/> > > < > > > http://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-incubating-M2/distribution/org/apache/openwebbeans/apache-openwebbeans-distribution/1.0.0-incubating-M2/ > > > > > > > > > > > > > > > > > > > > The .asc.md5 and .asc.sha1 hashes should be deleted as they > > serve > > > > no > > > > > > > purpose. > > > > > > > > > > > > > > The POM files in the source archives have the wrong version; > > they > > > > are using > > > > > > > 1.0.0-incubating-SNAPSHOT whereas they should have > > > > > > > 1.0.0-incubating-M2 > > > > > > > > > > > > > > This is a release blocker. Looks like the artifacts were built > > from > > > > > > > the wrong SVN checkout. > > > > > > > > > > > > > > The source archives have an additional top-level src/ > > directory > > > > which > > > > > > > is not usual. > > > > > > > > > > > > > > Normally this is included in the parent, e.g. > > > > > > > > > > > > > > apache-openwebbeans-distribution-1.0.0-incubating-M2-src > > > > > > > > > > > > > > rather than > > > > > > > > > > > > > > apache-openwebbeans-distribution-1.0.0-incubating-M2/src > > > > > > > > > > > > > > This is not a release-blocker. > > > > > > > > > > > > > > > SVN Tag > > > > > > > > ---------------------------- > > > > > > > > > > > > > > > > > > > > > > http://svn.apache.org/repos/asf/incubator/openwebbeans/tags/openwebbeans-1.0.0-incubating-M2/ > > > > > > > > > > > > > > There are some major problems with the NOTICE and LICENSE > > files. > > > > > > > > > > > > > > The NOTICE file must start with: > > > > > > > > > > > > > > Apache OpenWebBeans > > > > > > > Copyright 2008, 2009 The Apache Software Foundation > > > > > > > > > > > > > > The preceeding 4 lines need to be removed. > > > > > > > Also, the NOTICE file is much too long, it should be used for > > > > required > > > > > > > elements only, so remove any references to other ASF projects > > and > > > > all > > > > > > > the headers enclosed in == > > > > > > > > > > > > > > Some of the other entries include too much data. > > > > > > > > > > > > > > The LICENSES file only contains the Apache License. It must > > contain > > > > > > > all the required licenses. > > > > > > > > > > > > > > These are both release blockers. > > > > > > > > > > > > > > There is at least one file in SVN with inconsistent > > line-endings: > > > > > > > > > > > > > > svn pl -v openwebbeans-1.0.0-incubating-M2/samples/guess > > > > > > > Properties on > > > > > > > 'openwebbeans-1.0.0-incubating-M2\samples\guess': > > > > > > > svn: Inconsistent line ending style > > > > > > > > > > > > > > It looks like the svn:eol-style properties are missing from a > > lot > > > > of files. > > > > > > > > > > > > > > This makes it difficult to use the code except on OSes with > > the > > > > same > > > > > > > EOL as the file happens to be. > > > > > > > > > > > > > > This ought to be fixed before creating any new tags, because > > the > > > > tags > > > > > > > cannot be fixed later. > > > > > > > > > > > > > > > The release vote on the openwebbeans-dev mailing list > > resulted > > > > in three > > > > > > > +1 > > > > > > > > votes and no 0 or -1 votes from podling PMC members. > > > > > > > > > > > > > > My vote is -1, based on the problems with the N & L files, and > > the > > > > > > > incorrect version in the pom.xml > > > > > > > > > > > > > > > [VOTES] > > > > > > > > Kevan Miller +1 Binding (PPMC) > > > > > > > > Gurkan Erdogdu +1 (PPMC) > > > > > > > > Mark Struberg +1 (PPMC) > > > > > > > > > > > > > > > > [VOTE Thread] : > > > > > > > > > > > > > > http://www.mail-archive.com/openwebbeans-...@incubator.apache.org/msg00944.html > > > > > > > > > > > > > > > > More information about the project can be found here: > > > > > > > > [Incubation Status Page ] : > > > > > > > http://incubator.apache.org/projects/openwebbeans.html > > > > > > > > [Project Page] : > > > > > > > > > http://incubator.apache.org/openwebbeans/1.0.0-SNAPSHOT/index.html > > > > > > > > [Wiki Page] : > > http://cwiki.apache.org/OWB/ > > > > > > > > [Blog] : > > > > http://blogs.apache.org/OWB/ > > > > > > > > > > > > > > > > Thanks; > > > > > > > > > > > > > > > > > > > > > > > > Gurkan Erdogdu > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > To unsubscribe, e-mail: > > > > > > > general-unsubscr...@incubator.apache.org > > > > > > > For additional commands, e-mail: > > > > > > > general-h...@incubator.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > To unsubscribe, e-mail: > > > > > > > general-unsubscr...@incubator.apache.org > > > > > > > For additional commands, e-mail: > > > > > > > general-h...@incubator.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > To unsubscribe, e-mail: > > general-unsubscr...@incubator.apache.org > > > > > > For additional commands, e-mail: > > general-h...@incubator.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Gurkan Erdogdu > > > http://gurkanerdogdu.blogspot.com > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > -- > Gurkan Erdogdu > http://gurkanerdogdu.blogspot.com > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
