On 21/08/2009, sebb <seb...@gmail.com> wrote: > On 21/08/2009, Francis De Brabandere <franci...@gmail.com> wrote: > > > So sebb, what tool are you using there to come up with all those issues ;-) > > > Scripts to download and unpack the archives. > Scripts to check sigs and hashes. > > WinMerge and > > https://svn.apache.org/repos/private/committers/tools/releases/compare_dirs.pl > > Eyes ;-) >
And following links - sorry, just spotted that the NOTICE file says: "This product includes software originally developed by ESTEAM Software. For further information see http://www.empire-db.org"; However, the link redirects back to http://incubator.apache.org/empire-db/ Perhaps that should have some information on the provenance. > > On the distribution file(s). Is this standard practice described somewhere. > > > No, but just have a look at some other projects. > I'm not saying it's the only practice (cf. Apache Wicket), but the > majority of projects have two sets of archives, and it is ASF policy > to vote on the source, not binaries. > > > > Can you suggest a model project that is using maven? > > > Almost all of Commons now use Maven2. > > > > If we have binaries separated should we also provide libraries in that zip? > > > Yes, depending on the licensing of the 3rd party libraries. > These should be added a build time, not added to SVN. > But you should consider whether this will make the archive too large. > > You might wish to release 2 binary archives, one just empire-db and > one of dependencies. > > E.g. HttpComponents HttpClient does this. > > > > Since we moved to maven this is kind of a first release all over > > again... We're going to fix all issues and come back with a proper > > release later this month. > > > > Thanks for the thorough review. > > > OK, one more point I forgot to mention: the format of the hashes, i.e. > > target/dist/apache-empire-db-2.0.5-incubating.tar.gz: > 34 81 4D D7 5E EB 49 F1 50 49 64 91 2C 83 04 96 > > is not the normal format, and does not play well with automated checkers. > > The normal format is: > > 34814DD75EEB49F1504964912C830496 *apache-empire-db-2.0.5-incubating.tar.gz > > or possibly just > > 34814DD75EEB49F1504964912C830496 > > Likewise for the SHA-1 hash if provided. > > This is not a blocker, but please fix if possible. > > > > > > Francis > > > > > > On Fri, Aug 21, 2009 at 2:05 PM, sebb<seb...@gmail.com> wrote: > > > On 21/08/2009, Martijn Dashorst <martijn.dasho...@gmail.com> wrote: > > >> On Fri, Aug 21, 2009 at 1:52 PM, sebb<seb...@gmail.com> wrote: > > >> > There is only a combined source/binary archive, which is not > standard practise. > > >> > All other projects release a source archive; almost all also > release a > > >> > separate binary archive. > > >> > > >> > > >> FWIW, Apache Wicket has released combined binary/source archives since > > >> its inception. Not something that needs changing. > > >> > > >> > > >> > The archive does not have a DISCLAIMER file - yes, the disclaimer > text > > >> > is in README, but the general practise is for a separate file. > > >> > > >> > > >> DISCLAIMER should be next to LICENSE, NOTICE and README. Remember to > > >> remove upon graduation :-) > > >> > > >> > > >> > The NOTICE file is incorrect. The date is 2008, and the second > > >> > paragraph must be: > > >> > > > >> > This product includes software developed at > > >> > The Apache Software Foundation (http://www.apache.org/). > > >> > > > >> > i.e. switch the 2nd and 3rd paragraphs > > >> > > >> > > >> Should be fixed. > > >> > > >> > > >> > Minor points: > > >> > > > >> > It would be useful to include compiler source and target versions as > > >> > headers in the jar manifests (the manifests are otherwise good) > > >> > > >> > > >> Shouldn't maven do this already? [1] > > > > > > The headers referred to in [1] are present, I was referring to headers > such as: > > > > > > X-Compile-Source-JDK: 1.5 > > > X-Compile-Target-JDK: 1.5 > > > > > > These need to be added manually. Not essential, but can be very useful. > > > > > >> Martijn > > >> > > >> [1] > http://maven.apache.org/shared/maven-archiver/examples/manifest.html > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > >> For additional commands, e-mail: general-h...@incubator.apache.org > > >> > > >> > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > > > > > > > -- > > > > http://www.somatik.be > > Microsoft gives you windows, Linux gives you the whole house. > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
