On Tue, May 1, 2012 at 10:42 PM, Norbert Thiebaud <nthieb...@gmail.com> wrote:
<snip> > PS: the specific svn revisions here are not the central point, the > point is the lack of any discussion/scrutiny on any of these followed > by the self-fulfilling prophecy: "To be released the code must be > clean. Releasing imply a detailed IP review (RAT was run), so surely > if the release was approved by a vote then the release _is_ IP clean, > and therefore if it is released then it is clean". > Rob's 'holier than thou' public attitude on the topic remind me of the > old saying: "People who live in glass houses shouldn't throw stones. > Your argument is a form of the logical fallacy known as the "fallacy of the false dilemma", also called "false either/or" or "black-and-white thinking". You argue that either the code review must reach some absolute level of complete perfection or that it is no better than doing no review at all. Let's recast that argument. We are not able to test 100% of OpenOffice, from a path perspective with our current test cases. Although we do have a practice of recording bugs and fixing them, we have no practical way of achieving 100% perfection on defect detection and removal. Therefore (your argument would go) it is not worth testing at all, and we should not be allowed to tout the user benefits of what testing that we do perform. Now, you wouldn't make such an argument about testing, would you? Similarly, the Apache emphasis on IP review is not less important because of possible human error. In fact the multiple stages of review and approval are designed to give maximal opportunity to identify and fix such issues. This has worked very well for this project, and the reviews we've done have found and addressed many issues. It is far better than doing nothing. In the end, I'll take diligence over negligence any day. -Rob --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org