Looks good. +1
Craig On May 13, 2013, at 3:56 PM, Juan Pablo Santos Rodríguez wrote: > Hi all, > > the current tally, right now, is: > > +1 binding from Ant Elder (IPMC) > +1 binding from Siegfried Goeschl (Mentor) > +5 non binding from PPMC > > (all votes casted on jspwiki-dev@i.a.o) We still need one more +1 binding > vote to be able to release, so we'd be most grateful if someone could take > a look at it. > > thx in advance! > > > br, > juan pablo > > On Thu, May 9, 2013 at 8:29 PM, Juan Pablo Santos Rodríguez < > juanpablo.san...@gmail.com> wrote: > >> Hi Ant, >> >> thanks for the vote :-) >> >> Regarding the NOTICE file, specifically which comments? Right now has 4 >> entries, being the reasons behind each one: >> - fckconfig.js entry: published under MPL 2.0, so it requires to be in >> NOTICE >> >> - "Portions of this code donated by BaseN Corporation." entry: legal's >> advice [#1] was to keep this entry in NOTICE >> >> - SilkIconSet entry: published under Creative Commons Attribution 2.5 >> License, which in section 4.b states "If you distribute, publicly display, >> publicly perform, or publicly digitally perform the Work or any Derivative >> Works or Collective Works, You must keep intact all copyright notices [...]" >> >> - Slimbox: published under MIT license so shouldn't be there, as pointed >> in [#2]. However, as it's been modified, I thought of it as a derivative >> work and, it fell under section 4.d of the AL "You may add Your own >> attribution notices within Derivative Works that You distribute, alongside >> or as an addendum to the NOTICE text from the Work, provided that such >> additional attribution notices cannot be construed as modifying the >> License." >> >> Please note that I'm not saying they *should* be there, only why they are >> there. If there's anything wrong on that file we'll correct it ASAP (btw, a >> handy way to check if other projects are including specifics entries in >> NOTICE files for 3rd party libraries is to search for an specific >> dependency at [#4] and then checking the svn's NOTICE file of the projects >> using it) >> >> Regarding the missing DISCLAIMER, our distribution target didn't catch it. >> It's already fixed on trunk, although our plan is release 2.9.1 in order to >> start graduation discuss soon thereafter. >> >> @general: aside from Ant's vote, we've got another couple of votes at >> jspwiki-dev, so the tally right now is 5PPMC +1 votes, 1 +1 IPMC vote >> >> >> br, >> juan pablo >> >> [#1]: http://s.apache.org/7Hs >> [#2]: http://www.apache.org/dev/licensing-howto.html#permissive-deps >> [#3]: http://www.apache.org/licenses/LICENSE-2.0.html#redistribution >> [#4]: https://analysis.apache.org/dependencies/index >> >> >> On Thu, May 9, 2013 at 10:15 AM, ant elder <ant.el...@gmail.com> wrote: >> >>> Hi JSPWiki, I'm from the Incubator PMC and looking at your release. >>> >>> I give it a +1. >>> >>> There are a couple of nits. One is that it looks like the Incubation >>> DISCLAIMER text is missing from the binary zip. It is there in the >>> source artifact and tag though and we've let releases go with these >>> missing before so i don't think this is a blocker, fix it next time, >>> or better, graduate from the Incubator now so its not needed next >>> time. The NOTICE file still has some comments that probably aren't >>> needed there and they could be moved somewhere else like the README. >>> Again many Incubator releases have similar issues so i don't think >>> that should be a blocker and i can help you get that updated for the >>> next release. >>> >>> ...ant >>> >>> On Tue, May 7, 2013 at 10:16 PM, Juan Pablo Santos Rodríguez >>> <juanpablo.san...@gmail.com> wrote: >>>> Hi all, >>>> >>>> We've held a vote on jspwiki-dev for a 2nd RC of Apache JSPWiki >>>> 2.9.1-incubating [#1]. >>>> >>>> The vote on release candidate has been open for more than 72 hours on >>> the >>>> developer mailing list. After the voting timeframe, we have 3 >>> non-binding >>>> votes (from jspwiki developers). >>>> >>>> I'd therefore like to ask now the general incubator to check our release >>>> candidate. The release notes (fixed issues) are available at the Jira >>> Issue >>>> Tracker [#2]. >>>> >>>> Please find attached below the concrete details on the release and on >>> the >>>> vote. >>>> >>>> thanks in advance, >>>> juan pablo >>>> >>>> >>>> [#1] http://s.apache.org/UDD >>>> [#2] >>>> >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310732&version=12321249 >>>> =================================================== >>>> >>>> Note that we are voting upon the source (subversion tag and signed >>>> artifacts). Binaries are provided for convenience only. >>>> >>>> The tag to be voted upon: >>>> >>> http://svn.apache.org/repos/asf/incubator/jspwiki/tags/jspwiki_2_9_1_incubating_rc2 >>>> >>>> Source and binary files, with RAT report: >>>> http://people.apache.org/~juanpablo/releases/2.9.1-incubating-4-rc2/ >>>> >>>> Checksums: >>>> >>>> JSPWiki-2.9.1-incubating-4-bin.zip >>>> MD5: 58b7e2fd9290612762825683e81ca22d >>>> SHA1: 5eb4cfa7c7b00e2a002573c72f1e83c15f708e2b >>>> SHA512: >>>> >>> 0e1487d09044e0ce900194b42ff3e465ee96ebde1a75c0603715ec42bbf425b950c901bff87bbadf43173d3c91ced170ab0eebe4525706344642e68db069ba18 >>>> >>>> JSPWiki-2.9.1-incubating-4-src.zip >>>> MD5: 707b52ce9ca32fe012bcc3b1a79d8f96 >>>> SHA1: 41619359a04d49a2f5b58b8ba1a5d0c186fbbb1c >>>> SHA512: >>>> >>> 2c4f6e0b9e163d2b3ae60a091993598ed6e315a7f7b4c08a9232cbd0c1eccba4259818e0e9ab8a86350a0109924be21cc0627e8a549bbd52b14ca7b40dcccee0 >>>> >>>> JSPWiki's KEYS file containing PGP keys we use to sign the release: >>>> http://www.apache.org/dist/incubator/jspwiki/KEYS >>>> >>>> [ ] +1 Release this package as Apache JSPWiki 2.9.1-incubating >>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release >>>> [ ] -1 Do not release this package because... >>> >> >> Craig L Russell Architect, Oracle http://db.apache.org/jdo 408 276-5638 mailto:craig.russ...@oracle.com P.S. A good JDO? O, Gasp! --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org