Thanks Justin, we will check it out for the additional LICENSE issue. - Henry
On Sat, Feb 7, 2015 at 6:35 PM, Justin Mclean <justinmcl...@me.com> wrote: > Hi, > > +1 (binding) > > - signatures and hashes correct > - LICENSE and NOTICE correct but may have minor issue (see below) > - DISCLAIMER exits > - incubating in source package > - all source files have headers > - no unexpected binaries in release > - can compile source > > Minor LICENSE issue, looks like angular-scenario.js bundles other code, so > you may need to add Sizizzle / The Dojo Foundation and John Resig to LICENSE. > > Also fails to build with gradle 2.2.1 as it expects version 2.2, you may want > to update that. (if the check is removed you can build with 2.2.1) > > Thanks, > Justin > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
