Checking in the generated code and only conditionally running thrift would make checking this much easier.
On Mon, Feb 16, 2015 at 3:26 PM, Julien Le Dem <jul...@twitter.com.invalid> wrote: > You need thrift 0.7 > https://github.com/Parquet/parquet-mr/wiki/Developer-documentation > We should add a mention of this. > > On Monday, February 16, 2015, Justin Mclean <jus...@classsoftware.com> > wrote: > > > Hi, > > > > +0 binding (for now) as cant compile from source. Will try again > tomorrow. > > > > - hashes and signature correct > > - LICENSE and NOTICE have minor issues (see below) > > - DISCLAIMER exists > > - incubating in source package name > > - all source files have correct headers > > - no unexpected binary files in release > > - can't compile from source. mvn give this error: > > "/bin/sh: thrift: command not found" > > > > README.md has minimal instructions on compiling. > > > > Please fix this for next release: > > - SLF4J is MIT licensed, so this needs to be added to LICENSE > > > > Minor issues: > > - No need for Apache Spark in LICENSE > > - Year wrong in NOTICE > > > > Thanks, > > Justin > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > <javascript:;> > > For additional commands, e-mail: general-h...@incubator.apache.org > > <javascript:;> > > > > >
