I change my vote to +1 (non-binding), fixing for next release is good enough for me. :-)
Perhaps worth also checking that maven plugin (assembly?) and report upstream - simply picking last <license> is a bit fragile. On 31 Mar 2015 22:54, "Dmitriy Setrakyan" <dsetrak...@apache.org> wrote: > On Tue, Mar 31, 2015 at 2:22 PM, Stian Soiland-Reyes <st...@apache.org> > wrote: > > > ? > > My apologies for not looking up how to actually use Ignite :) > > > > > > The build still requires the edtFTPj dependency to compile, even > > without -Plgpl - using urideploy through Maven would always pull in > > the edtFTPj dependency. > > > > It is also in the zip: > > inflating: > > ignite-fabric-1.0.0/libs/optional/ignite-urideploy/edtFTPj-1.5.3.jar > > > > Apologies, I confused it with cron4j, which is part of LGPL-based optional > schedule module and is not included. > > > > > > > > I see it says a different license there > > > > > > > ignite-fabric-1.0.0/libs/optional/ignite-urideploy/licenses/edtftp-license.pdf > > (from http://www.enterprisedt.com/products/edtftpj/doc/license.pdf ) > > > > which is "Subject to payment of the Source License fee:" and have > > several requirements for notices (which may or may not be satisfied by > > you including that PDF :) ) > > > > > > This is a bit unclear to me.. have you paid that fee? Do I need to pay > > that fee to use urideploy? Can I give this compiled > > ignite-fabric-1.0.0.zip to a customer, or would they also need to pay > > a fee? > > > > You are absolutely right. I actually completely forgot about this one. > Looks like the license provided is wrong, and we have a license bug. The > actual license is LGPLv2. You can clearly see it from here: > https://enterprisedt.com/products/edtftpj/ > > Currently, we are not excluding it from the release binary by mistake and > can fix it in the next release. However, we do not include any edtFTPj > source code into Apache Ignite, so the source code of Apache Ignite is LGPL > free. During the build, it ends up in the "libs/optional" folder and is not > turned on, unless explicitly moved to the "libs" folder. > > We will definitely address it in the next release. Ticket has been filed: > https://issues.apache.org/jira/browse/IGNITE-660 > > > > > > > I guess this comes from > > > > > http://central.maven.org/maven2/com/enterprisedt/edtFTPj/1.5.3/edtFTPj-1.5.3.pom > > and some Maven plugin just picking the last <license> ? > > > > > > On 31 March 2015 at 16:43, Dmitriy Setrakyan <dsetrak...@apache.org> > > wrote: > > > On Tue, Mar 31, 2015 at 8:35 AM, Stian Soiland-Reyes <st...@apache.org > > > > > wrote: > > > > > >> That thread does not mention edtFTPj or the test dependencies. > > >> > > >> http://enterprisedt.com/products/edtftpj/ > > >> > > >> > > >> but if edtFTPj is optional, why is it then not marked as such in the > > >> modules/urideploy/pom.xml? > > >> > > >> If I comment out edtFTPj, then I get lots of compiler errors. > > >> > > > > > > Stian, edtFTPj is also optional (sorry, forgot to mention). I am not > sure > > > what you mean by commenting it, but the maven build does not include it > > > into the release with default settings, no need to change anything. > > > > > > - Execute "mvn clean package -DskipTests" with JDK 7 > > > - Go into "target" folder and unzip "ignite-fabric-1.0.0.zip" file > > > - You will notice that there is not a single LGPL dependency there. > > > > > > If users would like to explicitly include LGPL dependencies into their > > own > > > build, then they should build the project with the following command: > > > > > > "mvn clean package -DskipTests -Prelease,lgpl" > > > > > > These instructions are also listed in the DEVNOTES.txt. > > > > > > Hope this clarifies things. > > > > > > D. > > > > > > > > >> > > >> modules/urideploy is depended on by modules/spring which is depended > > >> on by lots of other modules, it does not look optional to me. > > >> > > >> On 31 March 2015 at 16:26, Marvin Humphrey <mar...@rectangular.com> > > wrote: > > >> > On Tue, Mar 31, 2015 at 8:16 AM, Stian Soiland-Reyes < > > st...@apache.org> > > >> wrote: > > >> >> -0 because of required LGPL dependencies. > > >> > > > >> > I think we established that these were optional and thus allowed > > during > > >> > the last release: > > >> > > > >> > http://s.apache.org/vfN > > >> > > > >> > As far as LGPL, to my knowledge, Ignite only has 2 optional LGPL > > >> > dependencies which are for the optional integration with the > > >> following > > >> > products: > > >> > > > >> > - Hibernate ORM, http://hibernate.org/orm/ > > >> > - JTS Topology Suite from VividSolutions for geospatial > indexing, > > >> > http://www.vividsolutions.com/jts/JTSHome.htm > > >> > > > >> > Marvin Humphrey > > >> > > > >> > > --------------------------------------------------------------------- > > >> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > >> > For additional commands, e-mail: general-h...@incubator.apache.org > > >> > > > >> > > >> > > >> > > >> -- > > >> Stian Soiland-Reyes > > >> Apache Taverna (incubating), Apache Commons RDF (incubating) > > >> http://orcid.org/0000-0001-9842-9718 > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > >> For additional commands, e-mail: general-h...@incubator.apache.org > > >> > > >> > > > > > > > > -- > > Stian Soiland-Reyes > > Apache Taverna (incubating), Apache Commons RDF (incubating) > > http://orcid.org/0000-0001-9842-9718 > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > >
