+1 (binding) Checked signature and hashes. Built and ran unit tests (jdk 1.8, mac os x).
Julian On Jul 20, 2015, at 1:36 PM, Ted Dunning <ted.dunn...@gmail.com> wrote: > +1 (binding) > > What I did: > > Checked signatures and hashes > Ran unit tests > Ran RAT, inspected exclusions > Searched for files with odd permissions, found many executable files > > > > What I suggest: > > Files that don't need to be executable should not be. There are 6 shell > scripts in the source, but there are another 30 files that are marked as > executable that should not be. > > > > On Mon, Jul 20, 2015 at 10:30 AM, Owen O'Malley <omal...@apache.org> wrote: > >> * Checked GPG signature and hashes. >> * Built and ran unit tests. >> * Checked that all java files had Apache headers. >> * All of the java files are in org.apache.kylin package. Only exceptions >> were in the >> atopcalcite module: >> * net.hydromatic.optiq.runtime >> * org.eigenbase.sql2rel >> Are those classes coming from a different package? Do you intend to >> repackage them? >> >> +1 (binding) >> >> >> On Sat, Jul 18, 2015 at 12:43 AM, Henry Saputra <henry.sapu...@gmail.com> >> wrote: >> >>> Signature file looks good >>> Hashes are checked (NOTE next time probably use sha512) >>> NOTICE file looks good >>> LICENSE file looks good >>> DISCLAIMER exists >>> No 3rd party exes. >>> >>> +1 (binding) >>> >>> >>> >>> On Thu, Jul 16, 2015 at 9:22 PM, Luke Han <luke...@apache.org> wrote: >>>> Hi all, >>>> >>>> The Apache Kylin community has voted on and approved a proposal to >>> release >>>> Apache Kylin 0.7.2 (incubating), the first release of Apache Kylin. >>>> >>>> We already have applied some suggestion >>>> in last vote attempt, please refer to below vote mail thread for >> detail. >>>> >>>> Proposal: >>>> http://s.apache.org/kylin-0.7.2-vote_rc2 >>>> >>>> Vote result: >>>> http://s.apache.org/kylin-0.7.2-vote_result >>>> >>>> 5 binding +1 votes >>>> 2 non-binding +1 votes >>>> No -1 votes >>>> >>>> >>>> The commit to be voted upon: >>>> >>> >> https://github.com/apache/incubator-kylin/commit/f7a28422645bc209b2c38bb05b24a340444f9066 >>>> >>>> Its hash is f7a28422645bc209b2c38bb05b24a340444f9066. >>>> >>>> The artifacts to be voted on are located here: >>>> >>> >> https://dist.apache.org/repos/dist/dev/incubator/kylin/apache-kylin-0.7.2-incubating-rc2/ >>>> >>>> The hashes of the artifacts are as follows: >>>> src.tar.gz.md5 334c0981d0a258f2d83402bdb75486dd >>>> src.tar.gz.sha1 c377bcb7be17e0ad5540ce2a3d1366cc0c451eda >>>> >>>> A staged Maven repository is available for review at: >>>> >> https://repository.apache.org/content/repositories/orgapachekylin-1008/ >>>> >>>> Release artifacts are signed with the following key: >>>> https://people.apache.org/keys/committer/lukehan.asc >>>> >>>> Pursuant to the Releases section of the Incubation Policy and with >>>> the endorsement of our mentors we would now like to request >>>> the permission of the Incubator PMC to publish the release. The vote >>>> is open for 72 hours, or until the necessary number of votes (3 +1) >>>> is reached. >>>> >>>> [ ] +1 Release this package >>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release >>>> [ ] -1 Do not release this package because... >>>> >>>> +1 from Luke >>>> >>>> Luke Han, on behalf of Apache Kylin PPMC >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>> For additional commands, e-mail: general-h...@incubator.apache.org >>> >>> >> --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
