Hi,

+1 binding, but please looking into the issues below for next release.

I checked:
- name contain incubating
- signature and hash good
- disclaimer exists
- NOTICE and LICENSE have some issues
- there a few source files without Apache headers e.g. python scripts in [1]
- no unexpected binary files

For NOTICE file:
- Year is incorrect
- There is no need to list MIT or BSD software in NOTICE [2]

LICENSE is missing:
-  Block UI Copyright 2011, Ben Lin (MIT) [3]
- "Copyright (c) Nicolas Gallagher and Jonathan Neal" for MIT backgrid filter 
[4]
- JQuery migrate [5]
- Qunit [6]
- bootstrap editable [7]
- bootstrap [8]
- jsDump [9]
- font awesome [10] (and perhaps open sans font as well)

The visual source [11] is MIT so I’m not sure why it’s not grouped with the 
other MIT licenses.

Note that most of these issues were raised for the last release candidate and 
haven’t been fixed. [12]

Also can the release be place in the correct location and not on people. [13]

Thanks,
Justin

1.  ./migration-util/ambari2.0-hdp2.2-ranger0.40/bin/
2. http://www.apache.org/dev/licensing-howto.html#permissive-deps
3. ./security-admin/src/main/webapp/scripts/modules/XAOverrides.js
4. 
./security-admin/src/main/webapp/libs/bower/backgrid-filter/css/backgrid-filter.css
5. ./security-admin/src/main/webapp/libs/bower/jquery/js/jquery-migrate.js 
6. ./security-admin/src/main/webapp/libs/bower/globalize/test/qunit/qunit.js
7. 
./security-admin/src/main/webapp/libs/bower/x-editable/js/bootstrap-editable.js
8. ./security-admin/src/main/webapp/libs/bower/bootstrap/js/bootstrap.js
9. ./security-admin/src/main/webapp/libs/bower/globalize/test/qunit/qunit.js
10. ./security-admin/src/main/webapp/fonts/fontawesome/*
11. ./security-admin/src/main/webapp/libs/other/visualsearch/js/visualsearch.js
12. http://apache.markmail.org/thread/aja7o2bodr45clcp
13. http://www.apache.org/dist/incubator/ranger/




Reply via email to