Hi, +1 binding
I checked: - name include incubating - signature and hashes good - disclaimer exits - LICENSE is OK but missing a couple of licenses - NOTICE has too much info - A couple of files are missing Apache headers, for example [1][5][6]. There may be others. - No unexpected binary files - Can compile from source NOTICE should only include the first 4 lines of test there’s no need to repeat the copyrights here. License is missing: - Fontawesome (MIT and SIL) [3] - Qunit (MIT) [7] - Jquery migrate (MIT) [8] - bootstrap [9] Probably MIT but depend on version used. - jsDump (inside Qunit) BSD licensed - Block UI (MIT) inside [10] Please fix this for the next release. I’m not sure how HijriCalendar.js [4] is licensed, assuming it permissive it will most likely need to be added to LICENSE. Thanks, Justin 1. migration-util/ambari2.0-hdp2.2-ranger0.40/bin/import_ranger_to_ambari.py 2. migration-util/ambari2.1-hdp2.3-ranger0.50/bin/import_ranger_to_ambari.py 3. security-admin/src/main/webapp/fonts/fontawesome/fontawesome-webfont.svg 4. security-admin/src/main/webapp/libs/bower/globalize/generator/HijriCalendar.js 5. apache-ranger-incubating-0.5.1/security-admin/src/main/webapp/libs/bower/globalize/generator/StringExt.cs 6. security-admin/src/main/webapp/libs/bower/globalize/generator/UmAlQuraCalendar.js 7. security-admin/src/main/webapp/libs/bower/globalize/test/qunit/qunit.js 8. security-admin/src/main/webapp/libs/bower/jquery/js/jquery-migrate.js 9. security-admin/src/main/webapp/themejs/1.3.0/bootstrap.min.js 10. security-admin/src/main/webapp/scripts/modules/XAOverrides.js --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
