Hi, +1 (binding)
Nice first release - well done. I checked: - release artefact contains incubating - DISCLAIMER exists - LICENSE is good - NOTICE (or perhaps LICENSE) is missing copyright from [1] - All (non bundled) source files have Apache header - No unexpected binary files in the release - Can compile from source Re missing copyright in NOTICE really up to the PPMC how you want to handle it. The Apache licensed bundled code doesn’t have a NOTICE file but if it did it would include at least the copyright line. If it did exist you would need to add that to NOTICE, as it doesn’t exist and the copyright holder is not the ASF, you may want to add this to LICENSE. Currently (IMO) there’s no clear policy on this and there’s probably differing options. You could of course do nothing and still be within the letter of policy i.e. bundle a non ASF Apache licensed code with no NOTICE, so there’s no need to do anything. Thanks, Justin 1. https://github.com/dpkp/kafka-python <https://github.com/dpkp/kafka-python>
