Hi,

+1 binding as long as the binary LICENSE/ NOTICE id looked ta and fixed for the 
next release. The source release is fine.

I checked:
- incubating in name
- DISCLAIMER exists
- source LICENSE and NOTICE good
- binary LICENSE and NOTICE has issues
- no unexpected binary files
- all source files have Apache headers
- can compile from source

The binary LICENSE and NOTICE needs a little work [1], could you please fix 
this for the next release.
- LICENSE is missing MIT licensed Asciidoctor and CodeRay (used in docs)
- The final jar contains a number of 3rd party licensed software that is not 
mentioned in LICENSE/NOTICE. This includes Dropwizard (Apache license with 
NOTICE file), Jackson Core, Databind and Annotations (Apache), Gogole Common 
libs, Joda Time (Apache with NOTICE), Jackson Afterburner (Apache?), slf4j 
(MIT), Logbock (EPL or GNU), Hibinate Validator (Apache), Glassfish (CDDL), Sun 
Expression Language Reference Implementation (CDDL), snakeyaml (Apache), Apache 
Commons, Jetty (Apache with NOTICE), Jersey (CDDL), H2K (CDDL), Javassist (MPL 
or GPL), Metrics (Apache), argparse4j (MIT), Arquillian (Apache?), Shrink-wrap 
(Apache?), JBoss Modules (Apache), JBoss logging (Apache).

Most of this is Apache licensed, but there a few NOTICE files that may effect 
your NOTICE [3] and there a couple of MIT licensed file. The CDDL / MPL license 
software which need to treated carefully. [4]

I may of missed a couple and you may want to double check the JBoss logging as 
at one point it was GPL not Apache licensed.

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html#binary
2. ./modules/server/lib/tamaya-server-0.2-incubating.jar
3. http://www.apache.org/dev/licensing-howto.html#alv2-dep
4. http://www.apache.org/legal/resolved.html#category-b
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to