+1 to that, Julian. You were absolutely right, I apologize I did not make it clear.
Really appreciate another set of eyes reviewing it. - Henry On Mon, May 23, 2016 at 5:15 PM, Julian Hyde <jh...@apache.org> wrote: > For the record, at the time that I reviewed the github repo, there was > code that was not merely *inspired* by Mondrian code, but *derived* > from Mondrian code. But that code has since been removed, so the issue > is resolved. With the usual precautions of a BD scan on the incoming > IP and ongoing diligence by the PPMC we'll be fine. > > Julian > > > On Mon, May 23, 2016 at 4:19 PM, Henry Saputra <henry.sapu...@gmail.com> > wrote: > > I thought the concern had been addressed? > > > > For Julian concern about Mondrian, the code was inspired by Mondrian but > do > > not have direct derivatives of the code. > > According to Jacky, the old code is no longer used. > > > > As for Julien concern about Parquet, the design seemed to be inspired by > > Parquet and ORC. > > And if needed, we could add reference to Parquet in the code > documentation. > > Since Parquet is ASF project, I believe we are in good shape in > CarbonData > > goes to ASF. > > > > If any other action item is needed please do suggest so we could make > > correction as part of incubation process. > > > > > > - Henry > > > > On Mon, May 23, 2016 at 4:12 PM, Roman Shaposhnik <ro...@shaposhnik.org> > > wrote: > > > >> On Mon, May 23, 2016 at 3:44 PM, Marvin Humphrey < > mar...@rectangular.com> > >> wrote: > >> > On Sun, May 22, 2016 at 10:57 PM, Jean-Baptiste Onofré < > j...@nanthrax.net> > >> wrote: > >> >> Hi Luke, > >> >> > >> >> I fully agree with you. The committers are already involved to > clean-up > >> the > >> >> repo (PRs have been created). > >> >> > >> >> IMHO, this step is decoupled from the proposal vote itself: the only > >> >> requirement is to do it for the code donation, after the proposal > vote. > >> > > >> > What will the process for this be? On this thread we have two outside > >> > authors recognizing their own work, but that's obviously not a > >> > realistic mechanism for identifying all potentially problematic IP. > >> > >> Given that this is a donation from a corporate entity a request for BD > >> (or similar) > >> scan results (if they are available) may help. That's how every > >> corporate-sponsored > >> donation (at least dozens I've been involved in) does risk mitigation > >> anyway. > >> > >> Thanks, > >> Roman. > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >> For additional commands, e-mail: general-h...@incubator.apache.org > >> > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
