Hi Justin, Thank you for reviewing the SystemML release candidate. I agree about the large number of artifacts at [1]. It would also help us in terms of project maintenance to decrease the number of artifacts that we are generating.
We will update trunk to remove the specified files. Will we need to begin voting again for another release candidate with these changes, or would it suffice that the next release will have this fix? Thank you, Deron On Tue, May 31, 2016 at 6:18 PM, Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > Sorry -1 (binding) due to unexpected binaries in the source release. > > For the source artefact I checked: > - signatures and hashes good > - file name contain incubating > - DISCLAIMER exists > - LICENSE and NOTICE correct > - There are unexpended binary in the source release (see below) > - All files have apache headers > - Can compile from source > > There’s a number of binary files included in the source release: > ls ./src/test/config/hadoop_bin_windows/bin > hadoop.dll hadoop.lib libwinutils.lib winutils.pdb > hadoop.exp hadoop.pdb winutils.exe > > There a large number of files at [1] so it’s not entirely clear what the > release artefacts are to vote on you might want to just include the .zip / > .tar.gz files next time. > > I also looked at the binary release, nice to see entirely different > LICENSE there based on the contents of the file. Minor issue there’s no > need to list the copyright for abego software or ANTLR software in the > NOTICE file as both are BSD licensed. [2] Please fix this for the next > release. > > Thanks, > Justin > > > 1. > https://dist.apache.org/repos/dist/dev/incubator/systemml/0.10.0-incubating-rc1/ > 2. http://www.apache.org/dev/licensing-howto.html#permissive-deps > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
