Hi Justin, can you confirm which artifacts are missing it please? typically reporting-ui references it ( https://github.com/apache/sirona/blob/23ca6902ba1a32650b06043f68d02c951629f0bb/server/reporting/reporting-ui/src/main/resources/META-INF/NOTICE#L39) and global one too ( https://github.com/apache/sirona/blob/23ca6902ba1a32650b06043f68d02c951629f0bb/NOTICE#L46 )
Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber <http://www.tomitribe.com> | JavaEE Factory <https://javaeefactory-rmannibucau.rhcloud.com> 2016-07-20 9:13 GMT+02:00 Justin Mclean <jus...@classsoftware.com>: > Hi, > > -1 binding due to LICENSE and NOTICE issues and missing DISCLAIMER files > > I checked: > - artefact names contain incubating > - signatures and hashes good > - source DISCLAIMER exists > - source LICENSE is missing many things. Note that the full text of the > license needs to be included in some cases (MIT/BSD) if it is not in the > header of the file, this is legally required by the terms of the license. > It best to add a pointer in the LICENSE file to the license in this case [1] > - source NOTICE contains stuff that should be in LICENSE. There is no need > to list permissive items in NOTICE [1][2] under most cases. > - NOTICE contains wrong year range (2008-2013). Has the project really > been incubating that long? > - No unexpected binaries in source release > - Source files have ASF headers > - Can compile from source > > LICENSE Is missing: > - jQuery Flot (MIT) which also includes jQuery resize event (dual > MIT/GPL) [3] Note that the various plugs have different authors and license > dates. > - Bootstrap (MIT) [4] > - normalize.css (MIT) [5] > - RequireJS (dual MIT/BSD) [7] > - jQuery table sorter (dual MIT/GPL) [8] > - Raphael (MIT with two copyright owners) [9] > - morris (BSD) [10] > - angular bootstrap nav tree (MIT) [11] > - angular (MIT) [12] > - jQuery (MIT) [13] > - moment (MIT) [14] > - ng grid (MIT) [15] > - angular ui bootstrap [16] > - bootstrap table [17] > - glyph icons halflings regular fonts (MIT?) [19] > - font awesome font (SIL OSF) [20] > - font awesome css (MIT) [21] > > No need to include in LICENSE as per [2]: > - bootstrap date time picker (Apache) [6] > - bootstrap table (Apache) [17] > - bootstrap (Apache) [18] Note however that both the Apache 2.0 and MIT > versions of Bootstrap are included. > - SB Admin HTML template (Apache) [22] > > For the connivence binaries: > - DISCLAIMERs are missing > - LICENSE files do not represent what is bundled [23] and are missing the > Apache license text > - NOTICE file is missing ASF part > - NOTICE file are likely missing information from bundled Apache v2 > licensed NOTICE files [2] > - May contain creative commons licensed Category X software? [24] > > Thanks, > Justin > > 1. http://www.apache.org/dev/licensing-howto.html#permissive-deps > 2 http://www.apache.org/dev/licensing-howto.html#alv2-dep > 3. > ./server/reporting/reporting-ui/src/main/webapp/js/plugins/flot/jquery.flot.js > 4. ./server/reporting/reporting-ui/src/main/webapp/js/bootstrap.3.2.0.js > 5. > ./server/reporting/reporting-webapp/src/main/resources/resources/css/bootstrap.css > 6. > ./server/reporting/reporting-webapp/src/main/resources/resources/js/bootstrap-datetimepicker.min.js > 7. ./server/reporting/reporting-ui/src/main/webapp/js/require-2.1.14.js > 8. > ./server/reporting/reporting-webapp/src/main/resources/resources/js/jquery.tablesorter.js > 9. > ./server/reporting/reporting-ui/src/main/webapp/js/plugins/morris/raphael-2.1.2.min.js > 10. > ./server/reporting/reporting-ui/src/main/webapp/js/plugins/morris/morris.min-0.5.0.js > 11. > ./server/reporting/reporting-ui/src/main/webapp/js/abn_tree_directive.js > 12. ./server/reporting/reporting-ui/src/main/webapp/js/angular-1.3.0.js > 13. ./server/reporting/reporting-ui/src/main/webapp/js/jquery-1.11.0.min.js > 14. ./server/reporting/reporting-ui/src/main/webapp/js/moment-2.8.1.min.js > 15. > ./server/reporting/reporting-ui/src/main/webapp/js/ng-grid-2.0.12.debug.js > 16 > ./server/reporting/reporting-ui/src/main/webapp/js/ui-bootstrap-tpls-0.11.0.js > 17. > ./server/reporting/reporting-webapp/src/main/resources/resources/js/bootstrap-tab.js > 18. > ./server/reporting/reporting-webapp/src/main/resources/resources/js/bootstrap.js > 19. ./server/reporting/reporting-ui/src/main/webapp/fonts/ > 20. > ./server/reporting/reporting-ui/src/main/webapp/font-awesome-4.1.0/fonts/ > 21. > ./server/reporting/reporting-ui/src/main/webapp/font-awesome-4.1.0/css/font-awesome.css > 22. > ./server/reporting/reporting-webapp/src/main/resources/resources/css/sb-admin.css > 23. http://www.apache.org/dev/licensing-howto.html#guiding-principle > 24. http://www.apache.org/legal/resolved.html#cc-sa > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
