Thanks, John. I have opened https://issues.apache.org/jira/browse/TEPHRA-231 to address your comments.
On Sat, May 27, 2017 at 7:52 AM, John D. Ament <johndam...@apache.org> wrote: > Gokul, > > The source release looks fine. The resulting binary needs work. Please > create a JIRA to correct the LICENSE file and the NOTICE file for the > binary distribution (when built: > tephra-distribution/target/apache-tephra-0.12.0-incubating): > > - Includes logback which is EPL/LGPL needs to be in LICENSE as EPL > - javax.inject should be CDDL > - Includes jsr305 which is an LGPL binary. There is a clean room > implementation that is more compliant > - guice includes a NOTICE to include in the binary > - ASM is BSD 3 clause, should be in LICENSE http://asm.ow2.org/license. > html > - Same for jline > > Other than that I'm +1 > > John > > On Fri, May 26, 2017 at 5:13 PM Gokul Gunasekaran <go...@apache.org> > wrote: > > > Hi all, > > > > This is a call for a vote on releasing Apache Tephra 0.12.0-incubating, > > release candidate 1. This is the fifth release of Tephra. > > > > Apache Tephra community has voted and approved the release. > > > > Vote thread: > > http://mail-archives.apache.org/mod_mbox/incubator-tephra- > dev/201705.mbox/% > > 3CCAFgkoWGFt1m4puB-T83i0QCgbyqpR7SEiMqJHL8b%3DxVCcSmvng%40mail.gmail.com > %3E > > <http://mail-archives.apache.org/mod_mbox/incubator-tephra- > dev/201705.mbox/%3CCAFgkoWGFt1m4puB-T83i0QCgbyqpR7SEiMqJHL8b% > 3DxVCcSmvng%40mail.gmail.com%3E> > > > > Result thread: > > > > http://mail-archives.apache.org/mod_mbox/incubator-tephra- > dev/201705.mbox/%3CCAFgkoWG5%3Dz9Fuu2xzLTiEOgFmTmZs53VRij7a > k3Zu2YY%2B2kciw%40mail.gmail.com%3E > > > > The source tarball, including signatures, digests, etc. can be found at: > > https://dist.apache.org/repos/dist/dev/incubator/tephra/0.12 > > .0-incubating-rc1/src > > > > The tag to be voted upon is v0.12.0-incubating: > > https://git-wip-us.apache.org/repos/asf?p=incubator-tephra.g > > it;a=shortlog;h=refs/tags/v0.12.0-incubating > > > > The release hash is 2bc62de4498bdb1d6b4647d6f102649d3f9d5df7: > > https://git-wip-us.apache.org/repos/asf?p=incubator-tephra.g > > it;a=commit;h=2bc62de4498bdb1d6b4647d6f102649d3f9d5df7 > > > > The Nexus Staging URL: > > https://repository.apache.org/content/repositories/orgapachetephra-1008/ > > > > Release artifacts are signed by: > > http://people.apache.org/keys/committer/gokul > > > > KEYS file available: > > https://dist.apache.org/repos/dist/dev/incubator/tephra/KEYS > > > > For information about the contents of this release, see: > > * > > https://dist.apache.org/repos/dist/dev/incubator/tephra/0. > 12.0-incubating-rc1/CHANGES.txt > > < > > https://dist.apache.org/repos/dist/dev/incubator/tephra/0. > 12.0-incubating-rc1/CHANGES.txt > > >* > > > > The vote will be open for 72 hours. > > > > [ ] +1 Release this package as Apache Tephra 0.12.0-incubating > > [ ] +0 no opinion > > [ ] -1 Do not release this package because ... > > > > Thanks, > > Gokul > > >
