-0 I started a review and noticed that the RELEASE_NOTES.md is for 0.1.0 and the copyright year in NOTICE should be updated.
I’ll stop for now. Regards, Dave > On Nov 3, 2017, at 10:26 AM, Ryan Blue <rb...@netflix.com.INVALID> wrote: > > -1 (binding) > > There are a few things that could be improved, but my -1 is because the > release tarball doesn’t match the release tag (inclusion of > .example-image), some files are missing the license header, and there is no > mention in the license file of mesos-protobuf that’s included in the > tarball. > > rb > > > Here are my other notes: > > The .sha file has a sha512 checksum, which should be in a .sha512 file. > Also (but minor), both .md5 and .sha files have a full path instead of a > relative path: > /Users/lresende/opensource/jupyter/incubator-toree-apache/dist/toree-src/toree-0.2.0-incubating-src.tar.gz > > I had to import the key using gpg --recv-keys EFB55DF1. Is there a KEYS > file published for Toree? > > The tarball currently unpacks into the current directory, which is unusual > for source tarballs. > > RAT checks fail for some files. Here’s the summary: > > !????? .jvmopts > !????? .example-image > !????? sparkr-interpreter/src/main/resources/README.md > !????? index.ipynb > !????? README.md > !????? RELEASE_NOTES.md > !????? etc/pip_install/MANIFEST.in > !????? etc/.src-release-ignore > > We should have license headers in the .md files, and the release process > should ideally use git archive to avoid picking up files from the local > working directory that aren’t part of the tagged release. > > This also distributes a few Jars: > > Archives: > + scala-interpreter/src/test/resources/TestJar2.jar > + scala-interpreter/src/test/resources/ScalaTestJar.jar > + scala-interpreter/src/test/resources/TestJar.jar > + kernel/lib/mesos-0.18.1-shaded-protobuf.jar > > I think the test Jars are fine, but LICENSE and NOTICE don’t mention > distributing mesos-protobuf. > > > On Wed, Nov 1, 2017 at 6:37 AM, Atri Sharma <atri.j...@gmail.com> wrote: > >> +1 >> -- Checked Headers >> -- Checked License >> -- Checked DISCLAIMER and Incubator policies >> >> On Thu, Oct 26, 2017 at 9:37 PM, Luciano Resende <luckbr1...@gmail.com> >> wrote: >>> Please vote to approve the release of Apache Toree 0.2.0-incubating >> (RC1). >>> >>> The PPM vote thread: >>> https://www.mail-archive.com/dev@toree.incubator.apache. >> org/msg01527.html >>> >>> And the result: >>> https://www.mail-archive.com/dev@toree.incubator.apache. >> org/msg01539.html >>> >>> Tag: v0.2.0-incubating-rc1 (01cd97e9bad04878a8014016c154a50e2a00f21d) >>> >>> https://github.com/apache/incubator-toree/tree/v0.2.0-incubating-rc1 >>> >>> All distribution packages, including signatures, digests, etc. can be >> found >>> at: >>> >>> https://dist.apache.org/repos/dist/dev/incubator/toree/0.2. >> 0-incubating-rc1/ >>> >>> Staging artifacts can be found at: >>> >>> https://repository.apache.org/content/repositories/orgapachetoree-1007 >>> >>> The vote is open for at least 72 hours and passes if a majority of at >> least >>> 3 +1 PMC votes are cast. >>> >>> [ ] +1 Release this package as Apache Toree 0.2.0-incubating >>> [ ] -1 Do not release this package because ... >>> >>> -- >>> Luciano Resende >>> http://twitter.com/lresende1975 >>> http://lresende.blogspot.com/ >> >> >> >> -- >> Regards, >> >> Atri >> l'apprenant >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> > > > -- > Ryan Blue > Software Engineer > Netflix
signature.asc
Description: Message signed with OpenPGP
