Hi, * Incubator DISCLAIMER included. * LICENSE file contains information that should go in the NOTICE. * Build worked fine on my desktop (Ubuntu 17.10, GCC 7.2.0).
* I'd put the install instruction somewhere more prominent than docs/install/index.md, and probably more CLI-friendly text document. Actually I was confused by the very different instruction from http://mxnet.apache.org/install/index.html So always take into account usability of your source release. * The KEYS file are not correctly linked in the VOTE email. They weren't that hard to find at https://dist.apache.org/repos/dist/dev/incubator/ mxnet/KEYS, but should be properly linked.. Event thoughmy vote for this RC1 is -1 (binding), because: * Binary nnvm/tvm/apps/android_rpc/gradle/wrapper/gradle-wrapper.jar is distributed without NOTICE. * Files' header contain, after the normative ASF license header, confusing copyright information that should be cleaned to avoid confusions. Anyway, congratulations for such big milestone. Based on my experience, the first incubating release is always difficult. So, if you need some more mentor power, I could jump into dev@mxnet to help your with the upcoming RCs. Cheers, On Mon, Nov 27, 2017 at 4:48 PM, Dave Fisher <dave2w...@comcast.net> wrote: > Hi - > > > On Nov 27, 2017, at 4:26 PM, Chris Olivier <cjolivie...@apache.org> > wrote: > > > > Hello All, > > > > > > This is a call for releasing Apache MXNet (incubating) 1.0.0, release > > candidate 0. > > > > > > Apache MXNet community has voted and approved the release. > > > > > > *Vote thread:* > > > > https://lists.apache.org/thread.html/568bf0c9960f14640b753a5fb6766c > > 7b0074339d286f405c04ffec96@%3Cdev.mxnet.apache.org%3E > > > > > > *Result thread:* > > > > https://lists.apache.org/thread.html/558a60f4d0c16b0311c96afd059082 > > ebde0f773c56a03cb9e00bc19f@%3Cdev.mxnet.apache.org%3E > > > > It looks like the true results are: > > IPMC Binding (mentor): 1 > Sebastian > > PPMC “Binding”: 3 > Chris Oliver > Indhu Bharanthi > Haibin Lin > > Contributors: 2 > > There is already one IPMC vote and you are looking for two more. > > Regards, > Dave > > > > > *The source tarball, including signatures, digests, etc. can be found > at:* > > > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.0.0.rc0/ > > > > > > > > *The release tag can be found here: * > > > > https://github.com/apache/incubator-mxnet/tree/1.0.0.rc0 > > > > > > > > *The release hash is *862629d056fe57e0afcf987f7708967bbe29e606* and can > be > > found here:* > > > > <https://github.com/apache/incubator-mxnet/commit/ > > 862629d056fe57e0afcf987f7708967bbe29e606> > > > > > > > > *Release artifacts are signed with the following key:* > > > > 69FF E8D6 1051 FFE7 E61B 02C2 80FD 81D7 703D F31B > > > > > > > > *KEY files are available here:* > > > > <https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.0.0.rc0/> > > > > > > > > *For information about the contents of this release, see:* > > > > <https://cwiki.apache.org/confluence/display/MXNET/ > > Apache+MXNet+%28incubating%29+1.0+Release+Notes> > > > > > > > > The vote will be open for at least 72 hours. > > > > > > [ ] +1 Release this package as 1.0.0 > > > > [ ] +0 no opinion > > > > [ ] -1 Do not release this package because... > > > > > > Thanks, > > > > > > Chris Olivier > >
