?On 25 February 2018 at 23:36, Jai Asher <jai.ashe...@gmail.com> wrote: > This is the fourth release candidate for Apache Pulsar, version > 1.22.0-incubating. > > It fixes the following issues: > https://github.com/apache/incubator-pulsar/milestone/11?closed=1 > > *** Please download, test and vote by Friday, Feb 23, 2018, 10:00 GMT.
Oo, I'll better hurry up then! :) Normally the wording is "The vote is open for at least 72 hours" -- you are OK to keep it open a bit longer if you need sufficient votes or have not tallied them yet. > Source and binary files: > https://dist.apache.org/repos/dist/dev/incubator/pulsar/ > pulsar-1.22.0-incubating-candidate-3/ Is it fourth of third release candidate? Use consistent numbering. Starting with "RC0" is a bit unusual.. > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachepulsar-1010/ My vote: +1 (binding) +0 checksums valid (I think) ? asc signatures (sorry, my machine lacks gpg today) +1 tag vs commit +0 src.tar.gz vs git tag (generate_protobuf.sh and generate_protobuf_docker.sh missing from dist - are they needed?) +1 mvn install +1 src LICENSE +1 bin NOTICE +0 src NOTICE -- copyright should extend into 2017-2018 +1 src/bin DISCLAIMER +1 bin LICENSE and licenses (but why extra LICENSE-HdrHistogram0.txt?) +0 bin NOTICE -- are all of these copyrights really forwarded from their NOTICE? +1 mvn apache-rat:check - well-documented excludes As an overall comment I think good work on the licenses! I did a spot check, and guava.jar does not have a NOTICE, so unless that was copied from a zip/tar that had such a NOTICE, then there would be nothing to propagate. On the other side netty.jar has a humongous NOTICE which somehow just becomes "Copyright 2014 The Netty Project" in your NOTICE -- this seems to violate their Apache license. Has this been discussed on legael? Your Git repository contains .gitignore.swp from vim which you probably want to delete. Your checksum files are in an unusual style: C1 B8 C8 91 23 92 6A 56 82 F6 E9 F3 25 86 8B 58 CA1B352F 9576C8CB F16258F8 DEABF8F6 E95A926F 665E2FD8 30A38532 8BC639C6 20FD34E6 6948396A CCD1A123 F072F93D 55D316EB EE34D208 9E0E9174 95AA09EE Normally the .md5 and .sha512 files contain the checksum only, in lowercase hex without spacing, e.g. c1b8c89123926a5682f6e9f325868b58 ca1b352f9576c8cbf16258f8deabf8f6e95a926f665e2fd830a385328bc639c620fd34e66948396accd1a123f072f93d55d316ebee34d2089e0e917495aa09ee This makes it easier to check against tools like md5sum and shasum. You didn't include .sha1 checksums, but extra points for .sha512 :) It is customary to include the checksums (at least md5) or the dist.apache.org svn revision in the [VOTE] email, to any avoid accidental last-minute-tampering confusion and to keep it in the mailing list archives. Tested with: Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T20:39:06+01:00) Maven home: /usr/local/share/maven Java version: 1.8.0_144, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac" -- Stian Soiland-Reyes http://orcid.org/0000-0001-9842-9718 --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
