Hi Justin I just checked the code of servicecomb-website, we keep the js and fonts into the repo, so we should treat the repo as source release but the source has the bundled items (js, and fonts). I guess the License statements[1] should be fine, please let me know if I miss anything.
For the NOTICE[2], I will the remove the dependencies statements, as they should not be there. [1] https://github.com/apache/incubator-servicecomb-website/blob/asf-site/LICENSE [2] https://github.com/apache/incubator-servicecomb-website/blob/asf-site/NOTICE Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Sat, Mar 3, 2018 at 4:36 PM, Willem Jiang <willem.ji...@gmail.com> wrote: > Hi Justin, > > Thanks for pointing out the NOTICE file issue. I think we messed the > usage of NOTICE and License file. It looks put the License files in the > License directory could be a good way. > > The NOTICE file you just point is for the servicecomb-website (which is > build by), not for the other servicecomb sub project. > As we just publish the website in apache, I'm not sure if the website is > kind of release. > If we treat it as a source release, I guess we don't need to mention those > dependencies js License and NOTICE, am I right? > > > Willem Jiang > > Blog: http://willemjiang.blogspot.com (English) > http://jnn.iteye.com (Chinese) > Twitter: willemjiang > Weibo: 姜宁willem > > On Sat, Mar 3, 2018 at 3:57 PM, Justin Mclean <jus...@classsoftware.com> > wrote: > >> Hi., >> >> For those not wanting to download the release and unpack it, here's the >> current NOTICE file [1] >> >> You’ll note it contains permissive license information (which should be >> in the license file), links to web sites rather than pointers to license >> text (license information can change over time and again should be in >> license) and mentions non bundled items (only bundled items need to be >> mentioned in license and notice). >> >> Take for instance the license link to Font Awesome. It points to version >> 5 which isn’t in any release, 4.7 is in a binary release but not the source >> release. >> >> Thanks, >> Justin >> >> 1. https://github.com/apache/incubator-servicecomb-website/blob >> /asf-site/NOTICE >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> >
