Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-alpha(2nd round)

[???? Sheng Wu]

Hi Justin


Right now, I updated our rat exclude config as following, is this allowed? The 
concern may about JSON file for our test cases data and frontend/UI dependency 
descriptions, but JSON format is not allowed to add the header.


<plugin>
    <groupId>org.apache.rat</groupId>
    <artifactId>apache-rat-plugin</artifactId>
    <version>0.12</version>
    <configuration>
        <excludes>
            <exclude>**/target/**</exclude>
            <exclude>**/DISCLAIMER</exclude>
            <exclude>**/licenses/**</exclude>
            <exclude>**/codeStyle.xml</exclude>

            <!-- IDE files -->
            <exclude>**/*.iml</exclude>
            <exclude>**/.idea/**</exclude>
            <exclude>**/*.classpath</exclude>
            <exclude>**/.project</exclude>
            <exclude>**/.settings/**</exclude>
            <exclude>**/dependency-reduced-pom.xml</exclude>

            <!-- UI IDE configs -->
            <exclude>**/skywalking-ui/.editorconfig</exclude>
            <!-- UI Compiler configs -->
            <exclude>**/skywalking-ui/.webpackrc.js</exclude>
            <exclude>**/skywalking-ui/.roadhogrc.mock.js</exclude>
            <!-- UI style check files -->
            <exclude>**/skywalking-ui/.eslintrc</exclude>
            <exclude>**/skywalking-ui/.stylelintrc</exclude>

            <!-- git files -->
            <exclude>**/.gitignore</exclude>
            <exclude>**/.gitmodules</exclude>
            <exclude>**/.git/**</exclude>

            <!-- CI files -->
            <exclude>**/.travis.yml</exclude>

            <!-- GitHub files -->
            <exclude>**/.github/**</exclude>

            <!-- document files -->
            <exclude>**/*.md</exclude>
            <excldue>**/*.MD</excldue>
            <exclude>**/*.txt</exclude>
            <exclude>**/docs/**</exclude>

            <!-- Test cases data in JSON format -->
            <exclude>**/src/test/resources/json/*.json</exclude>

            <!-- front end libary and generated files -->
            <exclude>**/skywalking-ui/node_modules/**</exclude>
            <exclude>**/skywalking-ui/node/**</exclude>
            <exclude>**/skywalking-ui/dist/**</exclude>

            <!-- web UI dependencies descriptions -->
            <exclude>skywalking-ui/package.json</exclude>
            <exclude>skywalking-ui/package-lock.json</exclude>
        </excludes>
    </configuration>
    <executions>
        <execution>
            <phase>verify</phase>
            <goals>
                <goal>check</goal>
            </goals>
        </execution>
    </executions>
</plugin>


------------------
Sheng Wu
Apache SkyWalking original creator and PPMC member


 




------------------ Original ------------------
From:  "Justin Mclean"<jus...@classsoftware.com>;
Date:  Sat, Mar 24, 2018 10:48 AM
To:  "general"<general@incubator.apache.org>;

Subject:  Re: [VOTE] Release Apache SkyWalking (incubating) version 
5.0.0-alpha(2nd round)



Hi,

Perhaps a silly question but I notice several people say they used rat to check 
this release. Rat clearly shows the jars, does rat need to flag these in a more 
serious way or were they hidden by a too wide rat exclusion file?

Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org