If it is part of a releasable artifact, then source needs to be provided. > On May 14, 2018, at 2:16 PM, Sijie Guo <guosi...@gmail.com> wrote: > > On Mon, May 14, 2018 at 10:53 AM, Matt Sicker <boa...@gmail.com> wrote: > >> I'm not sure about a specific policy, but sources by definition aren't the >> binaries. Sources combine with a tool or tools to create binaries. >> > > Okay. But this is a test "resource" used by other sources on testing. > > Image you are writing an image processing library, you include some > "images" for testing the library. Is it allowed to include those "images" > in the source release? > > If you change "image" to "functions", pulsar-functions provides a > framework/library for processing functions, we include some user-defined > "functions" (aka jars) as test resources for testing the library. Is it > allowed or not? > > From what I can see here, the jars included in source binary are test > resources for testing. What is the ASF policy for handling test resources? > > > - Sijie > > > > >> >> On 14 May 2018 at 12:41, Sijie Guo <guosi...@gmail.com> wrote: >> >>> On Sat, May 12, 2018 at 3:52 PM, Justin Mclean <jus...@classsoftware.com >>> >>> wrote: >>> >>>> Hi, >>>> >>>> Sorry but it’s -1 binding due to compiled code in source release. >>>> >>> >>> >>> Can anyone point me the ASF policy page about this - "compiled code in >>> source release"? >>> >>> >>>> >>>> Frankly I’m surprised to see so many +1s with this obvious issue. >>>> >>>> I checked: >>>> - incubating in name >>>> - signatures and hashes correct >>>> - DISCLAIMER exists >>>> - LICENSE and NOTICE good >>>> - Unexpected jar in source release [1] >>>> - All source files have headers >>>> >>>> Thanks, >>>> Justin >>>> >>>> >>>> 1. pulsar-functions/utils/src/test/resources/multifunction.jar >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>>> For additional commands, e-mail: general-h...@incubator.apache.org >>>> >>>> >>> >> >> >> >> -- >> Matt Sicker <boa...@gmail.com> >>
--------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
