> Minor issue is that LICENSE is missing mention of these files [1][2][3] (but includes their license), be nice to fix that for the net release.
Justin, you're right. That's coming from that the 1st part LICENSE.bin.txt file is taken from source tgz LICENSE file. There, we mention these files since the sources are bundled in our package. As I understand, the right way for the binary distribution would be to just mention these as the other dependencies, without mentions to the source files, correct? Thanks, Matteo On Fri, May 25, 2018 at 6:39 PM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 (binding) > > I checked: > - incubating in name > - DISCLAIMER exists > - LICENSE is OK and NOTICE good > - All source files have ASF headers > - No unexpected binary files > - Can compile from source > > Minor issue is that LICENSE is missing mention of these files [1][2][3] > (but includes their license), be nice to fix that for the net release. > > Thanks, > Justin > > 1. ./pulsar-client-cpp/lib/checksum/int_types.h > 2. ./pulsar-client-cpp/lib/checksum/crc32c_sse42.h > 3. ./pulsar-client-cpp/lib/checksum/crc32c_sse42.cc > 4. ./pulsar-client-cpp/lib/checksum/gf2.hpp > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Matteo Merli <mme...@apache.org>
