Hi Willem,
the license headers for protobuf source files were fixed few days ago in
https://github.com/apache/incubator-pulsar/pull/1971/files
The version of Netty dependencies included in the bin tgz were also already
fixed earlier in the master branch. We have been refactoring the shading and
dependency exclusions. Just double-checked the current bin tgz from snapshot
and it looks correct:
------------------------------------------------------------------------------------
$ tar tvfz all/target/apache-pulsar-2.1.0-incubating-SNAPSHOT-bin.tar.gz |
grep io.netty
-rw-r--r-- 0 mmerli staff 3809972 May 29 14:17
apache-pulsar-2.1.0-incubating-SNAPSHOT/lib/io.netty-netty-all-4.1.22.Final.jar
-rw-r--r-- 0 mmerli staff 2766507 Nov 27 2017
apache-pulsar-2.1.0-incubating-SNAPSHOT/lib/io.netty-netty-tcnative-boringssl-static-2.0.7.Final.jar
-rw-r--r-- 0 mmerli staff 1308662 Mar 31 2017
apache-pulsar-2.1.0-incubating-SNAPSHOT/lib/io.netty-netty-3.10.1.Final.jar
------------------------------------------------------------------------------------
Thanks,
Matteo
On Fri, Jun 15, 2018 at 5:41 PM Willem Jiang <willem.ji...@gmail.com> wrote:
> +1 (binding)
>
> I checked:
>
> Signing key, and verify the check sum.
> License files and Notice files are OK
> I can built the binary kit from source.
>
> Please let me know when you commit the fix of source code license and clean
> up the netty version issue.
> I will keep an eye on the 2.1 branch to make sure those issue are fixed.
>
>
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Fri, Jun 15, 2018 at 5:22 AM, Matteo Merli <mme...@apache.org> wrote:
>
> > Hi WIllem,
> >
> > the 2.0.1 candidate was already being voted on the dev@pulsar list when
> > the
> > comments on 1.22.1 release were made here on incubator list, otherwise we
> > would have included the changes.
> >
> > 2.0.1 is a patch release in which we are trying to fix some issues
> reported
> > by
> > users in the 2.0.01-rc1 release from a couple of weeks back.
> >
> > Since at least a couple of issues were impacting users, we were trying to
> > get
> > a fix out ASAP. In particular we found packaging related issues that
> > impacted:
> > * Pulsar python client lib
> > * Pulsar proxy startup
> >
> > Master branch is already set on 2.1 release and we just applied few
> commits
> > to fix the non-functioning features.
> >
> > The idea was to fix netty packaging and protobuf license headers for 2.1,
> > for
> > which we plan to start the release process by next week.
> >
> > Matteo
> >
> > On Wed, Jun 13, 2018 at 6:24 PM Willem Jiang <willem.ji...@gmail.com>
> > wrote:
> >
> > > Hi Matto,
> > >
> > > I just checked the source code, the License header issue is still
> there.
> > > pulsar-common/src/main/java/org/apache/pulsar/common/util/
> > > protobuf/ByteBufCoded{Input,Output}Stream.java
> > >
> > > There are still bunch different version of netty jars in the lib
> > directory.
> > >
> > > My suggestion is we need fix these issues that we found in the last
> vote
> > > before starting a new vote.
> > >
> > >
> > > Willem Jiang
> > >
> > > Twitter: willemjiang
> > > Weibo: 姜宁willem
> > >
> > > On Tue, Jun 12, 2018 at 6:00 AM, Matteo Merli <mme...@apache.org>
> wrote:
> > >
> > > > This is the second release candidate for Apache Pulsar, version
> > > > 2.0.1-incubating.
> > > >
> > > > Link to the vote on dev@pulsar list
> > > > https://lists.apache.org/thread.html/620813d66d43a43680d3afd587e72f
> > > > 0d6f9607f1566aa88ef73d359c@%3Cdev.pulsar.apache.org%3E
> > > >
> > > > Pulsar is a highly scalable, low latency messaging platform running
> on
> > > > commodity hardware.
> > > > It provides simple pub-sub semantics over topics, guaranteed
> > > at-least-once
> > > > delivery of
> > > > messages, automatic cursor management for subscribers, and
> > > geo-replication.
> > > >
> > > > This is a patch release that fixes few issues identified in previous
> > > > release 2.0.0-rc1-incubating.
> > > >
> > > > It fixes the following issues:
> > > > https://github.com/apache/incubator-pulsar/milestone/14?closed=1
> > > >
> > > > *** Please download, test and vote on this release. This vote will
> stay
> > > > open
> > > > for at least 72 hours ***
> > > >
> > > > Note that we are voting upon the source (tag), binaries are provided
> > for
> > > > convenience.
> > > >
> > > > Source and binary files:
> > > > https://dist.apache.org/repos/dist/dev/incubator/pulsar/
> > > > pulsar-2.0.1-incubating-candidate-2/
> > > >
> > > > SHA-1 checksums:
> > > >
> > > > 5acd63f8aa1fa75f386df7b9fd803a943978e609
> > > > apache-pulsar-2.0.1-incubating-bin.tar.gz
> > > > 312bc0f1ae170c1d2dc38b1e362fb50f82c00525
> > > > apache-pulsar-2.0.1-incubating-src.tar.gz
> > > >
> > > > Maven staging repo:
> > > > https://repository.apache.org/content/repositories/
> > orgapachepulsar-1020
> > > >
> > > >
> > > > The tag to be voted upon:
> > > > v2.0.1-incubating-candidate-2 (fd47532380d770e4fd78cabe71dea2
> > 93fc2f0e06)
> > > > https://github.com/apache/incubator-pulsar/releases/tag/
> > > > v2.0.1-incubating-candidate-2
> > > > <https://github.com/apache/incubator-pulsar/releases/tag/
> > > > v2.0.1-incubating-candidate-1>
> > > >
> > > > Pulsar's KEYS file containing PGP keys we use to sign the release:
> > > > https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
> > > >
> > > > Please download the the source package, and follow the README to
> build
> > > > and run the Pulsar standalone service.
> > > > --
> > > > Matteo Merli
> > > > <mme...@apache.org>
> > > >
> > >
> > --
> > Matteo Merli
> > <mme...@apache.org>
> >
>
--
Matteo Merli
<mme...@apache.org>
