+1 (binding) So far I've checked: * signatures and digests * source releases file layouts * matched git tags and commit ids * incubator suffix and disclaimer * LICENSE & NOTICE files look good * no binary files in the source release * clean build (osx 10.12.6)
Some minor details I'd like to comment: * I don't understand what's the purposed of CODEOWNERS file in the source release * I've noticed the patch release is not included in the README's changelog. On Fri, Jun 22, 2018 at 12:16 PM Anirudh <anirudh2...@gmail.com> wrote: > Hi all, > > This is a call for releasing Apache MXNet (incubating) 1.2.1, release > candidate RC0. > > Apache MXNet (incubating) community has voted and approved the release. > > Vote thread: > > https://lists.apache.org/thread.html/52a6487bc1389d8865ccc0e42ade49 > edde02c061090389616c8088d5@%3Cdev.mxnet.apache.org%3E > > Results thread: > > https://lists.apache.org/thread.html/1d833bc94897132590950668eaff7d > 7e253894e2c274b1223ef733e1@%3Cdev.mxnet.apache.org%3E > > The source tarball, including signatures, digests etc. can be found at: > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.2.1.rc0/ > > The release tag can be found here: > > https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0 > > <https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0> > The release hash is daa957c9c811b1abd09b98e8fb5ff2c06cad9ad8 and can be > found here: > > https://github.com/apache/incubator-mxnet/commit/ > daa957c9c811b1abd09b98e8fb5ff2c06cad9ad8 > > Release artifacts are signed with the following key: > > > 0D04 3D0F 92CA 7333 22A8 D131 9067 CC8E AF55 CD6D > > > KEYS file available: > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS > > The vote will end at Tuesday June 26th, 12:15 PDT. > > [ ] +1 Release this package as 1.2.0 > [ ] +0 no opinion > [ ] -1 Do not release this package because ... > > Anirudh >
