Thanks Justin. I will remove the md5.

Abhishek

On Sun, Jul 1, 2018 at 3:02 AM Justin Mclean <jus...@classsoftware.com>
wrote:

> Hi,
>
> +1 (binding)
>
> Please remove the md5 hash from the release area before releasing as these
> should not longer be used.
>
> I checked:
> - incubating in artefacts name
> - signatures ands hashes correct
> - DISCLAIMER exists
> - LICENSE is missing a license
> - NOTICE is correct
> - Source file have headers, but there a few shell scripts missing them
> [1][2][3][4][5]
> - can compile from source
>
> LICENSE is missing license for the glyphicons-halflings font. [6]
>
> Thanks,
> Justin
>
> 1. apache-gobblin-incubating-sources-0.12.0/bin/gobblin-cluster-worker.sh
> 2. apache-gobblin-incubating-sources-0.12.0/bin/gobblin-service.sh
> 3. apache-gobblin-incubating-sources-0.12.0/bin/gobblin-cluster-master.sh
> 4.
> apache-gobblin-incubating-sources-0.12.0/gobblin-aws/src/test/resources/workerCloudInit.sh
> 5.
> apache-gobblin-incubating-sources-0.12.0/gobblin-aws/src/test/resources/masterCloudInit.sh
> 6.
> apache-gobblin-incubating-sources-0.12.0/gobblin-admin/src/main/resources/static/fonts/glyphicons-halflings-regular.*
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Reply via email to