On 19 July 2018 at 11:16, Bolke de Bruin <bdbr...@gmail.com> wrote: > Hi Sebb, > > Gotcha. The vote considers the source package, but arguably the binary > package is pretty close. The binary package does contain a LICENSE and NOTICE > file, it misses the specific (license)files mentioned in the LICENSE file. > The list normally would also be different between source and binary as some > of the files (code) do not end up in the binary package (ie. from tests). > > So adding the “license” folder to the binary package is on the list, but I > hope you allow us to do this for the next release as it is just a convenience > package really. > > What say you?
I am not keen on approving an artifact without the required N&L files. Given that it is a convenience package, you could just delete it and release the source alone. Do others think it's OK to let it be downloaded as is without the required files? > Cheers > Bolke > > >> On 19 Jul 2018, at 10:33, sebb <seb...@gmail.com> wrote: >> >> On 19 July 2018 at 09:15, Bolke de Bruin <bdbr...@gmail.com> wrote: >>> Hi Yang, >>> >>> The source package is the one was voted upon with the PMC and is under vote >>> now. >>> The binary package is just a convenience package and not the artefact voted >>> upon. The source package does contain >>> the files. >> >> However if you release the binary package, it must have NOTICE and >> LICENSE files, and these must agree with the contents of the package. >> >>> * kerberos: airflow/api/auth/backend/kerberos_auth.py >>> * elasticmock: tests/utils/log/elasticmock >>> * licenses: licenses/ >>> >>> Adding the “licenses/“ folder to the binary package is probably a good idea >>> so we will do so next release. Tests are not included in the binary release >>> for obvious reasons. >>> >>> Can you please make sure you are reviewing the right artefact? >>> >>> Cheers >>> Bolke >>> >>> >>>> On 19 Jul 2018, at 08:35, Yang Bo <oaky...@gmail.com> wrote: >>>> >>>> Hi Bruin, >>>> >>>> Sorry. I rechecked and found that I downloaded the binary package< >>>> https://dist.apache.org/repos/dist/dev/incubator/airflow/1.10.0rc2/apache-airflow-1.10.0rc2+incubating-bin.tar.gz> >>>> instead of the source package. >>>> The licenses folder is missing and I can't find files relating to >>>> elasticmock or flask-kerberos. >>>> >>>> On Thu, Jul 19, 2018 at 1:28 PM Bolke de Bruin <bdbr...@gmail.com> wrote: >>>> >>>>> Hi Yang, >>>>> >>>>> Thanks for reviewing. To your points. >>>>> >>>>> 1. I verified the number of licenses we are referring to (14) and the >>>>> number of licenses included (14). They are equal. Which ones are you >>>>> missing? >>>>> 2. Flask-Kerberos is actually bundled and part of the source distribution. >>>>> Also elasticmock is included as part of the tests. >>>>> 3. Good point. We will do so as part of the next release. >>>>> >>>>> You also mentioned that some .pyc files are included. The files you are >>>>> referring to are not part of the source tar.gz as far as I can see. I >>>>> downloaded the tar.gz, unpacked it and checked for the files you >>>>> mentioned. >>>>> >>>>> Cheers >>>>> Bolke >>>>> >>>>> Verstuurd vanaf mijn iPad >>>>> >>>>>> Op 19 jul. 2018 om 03:56 heeft Yang Bo <oaky...@gmail.com> het volgende >>>>> geschreven: >>>>>> >>>>>> There are also some binary files (*.pyc) in the airflow/config_templates. >>>>>> Those should be removed. >>>>>> >>>>>>> On Thu, Jul 19, 2018 at 9:51 AM Yang Bo <oaky...@gmail.com> wrote: >>>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> I found several minor issues regarding the LICENSE in the source >>>>> release. >>>>>>> 1. The LICENSE states that there are corresponding >>>>>>> licenses/LICENSE-[project] file for third parties but they do not exist. >>>>>>> 2. There are some libraries that are not bundled in the source release >>>>> but >>>>>>> are listed in the LICENSE file, e.g. ElasticMock, flask-kerberos etc. >>>>> The >>>>>>> LICENSE file should only contain what's actually bundled. >>>>>>> 3. It's better to provide the version in the LICENSE for third parties >>>>>>> because the license term may change between versions. >>>>>>> >>>>>>>> On Thu, Jul 19, 2018 at 2:40 AM Bolke de Bruin <bdbr...@gmail.com> >>>>> wrote: >>>>>>>> >>>>>>>> Hello Incubator PMC’ers, >>>>>>>> >>>>>>>> The Apache Airflow community has voted and approved the proposal to >>>>>>>> release >>>>>>>> Apache Airflow 1.10.0 (incubating) based on 1.10.0 Release Candidate >>>>> 2. We >>>>>>>> now kindly request the Incubator PMC members to review and vote on this >>>>>>>> incubator release. >>>>>>>> >>>>>>>> Airflow is a platform to programmatically author, schedule, and monitor >>>>>>>> workflows. Use Airflow to author workflows as directed acyclic graphs >>>>>>>> (DAGs) of tasks. The airflow scheduler executes your tasks on an array >>>>> of >>>>>>>> workers while following the specified dependencies. Rich command line >>>>>>>> utilities make performing complex surgeries on DAGs a snap. The rich >>>>> user >>>>>>>> interface makes it easy to visualize pipelines running in production, >>>>>>>> monitor progress, and troubleshoot issues when needed. When workflows >>>>> are >>>>>>>> defined as code, they become more maintainable, versionable, testable, >>>>> and >>>>>>>> collaborative. >>>>>>>> >>>>>>>> In this release with took special care of: >>>>>>>> >>>>>>>> * Correct License Headers >>>>>>>> * Removing potential GPL dependency >>>>>>>> * Better formatting of Disclaimer >>>>>>>> >>>>>>>> After a successful IPMC vote Artifacts will be available at: >>>>>>>> >>>>>>>> https://www.apache.org/dyn/closer.cgi/incubator/airflow < >>>>>>>> https://www.apache.org/dyn/closer.cgi/incubator/airflow> >>>>>>>> >>>>>>>> Public keys are available at: >>>>>>>> >>>>>>>> https://www.apache.org/dist/incubator/airflow/ < >>>>>>>> https://www.apache.org/dist/incubator/airflow/> >>>>>>>> >>>>>>>> apache-airflow-1.10.0rc2+incubating-source.tar.gz >>>>>>>> < >>>>>>>> >>>>>>>> >>>>> https://dist.apache.org/repos/dist/dev/incubator/airflow/1.10.0rc2/apache-airflow-1.10.0rc2+incubating-source.tar.gz >>>>>>>> < >>>>>>>> >>>>> https://dist.apache.org/repos/dist/dev/incubator/airflow/1.10.0rc2/apache-airflow-1.10.0rc2+incubating-source.tar.gz >>>>>>>>> >>>>>>>>> >>>>>>>> is a source release that comes with INSTALL instructions. Along with >>>>> it, >>>>>>>> for >>>>>>>> convenience, find the binary Python "sdist" as >>>>>>>> apache-airflow-1.10.0rc2+incubating-bin.tar.gz >>>>>>>> < >>>>>>>> >>>>>>>> >>>>> https://dist.apache.org/repos/dist/dev/incubator/airflow/1.10.0rc2/apache-airflow-1.10.0rc2+incubating-bin.tar.gz >>>>>>>> < >>>>>>>> >>>>> https://dist.apache.org/repos/dist/dev/incubator/airflow/1.10.0rc2/apache-airflow-1.10.0rc2+incubating-bin.tar.gz >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> Vote thread: >>>>>>>> >>>>>>>> >>>>> https://mail-archives.apache.org/mod_mbox/airflow-dev/201807.mbox/%3c9c7820e4-63c7-4b2c-9a89-bef6dcbc0...@gmail.com%3E >>>>>>>> < >>>>>>>> >>>>> https://mail-archives.apache.org/mod_mbox/incubator-airflow-dev/201712.mbox/%3CCABYbY7ecu8F8sp=gvZrvW3knj=qpdcuzu-jh02kngjgoezh...@mail.gmail.com%3E >>>>>>>>> >>>>>>>> >>>>>>>> Git tag: >>>>>>>> https://github.com/apache/incubator-airflow/releases/tag/1.10.0rc2 >>>>>>>> >>>>>>>> The vote will be open for at least 72 hours and until the necessary >>>>>>>> number of >>>>>>>> votes are reached. >>>>>>>> >>>>>>>> Members please be sure to indicate "(Binding)" with your vote which >>>>> will >>>>>>>> help in tallying the vote(s). >>>>>>>> >>>>>>>> * Here is my +1 (non-binding) * >>>>>>>> >>>>>>>> Cheers, >>>>>>>> Bolke >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Best Regards, >>>>>>> Yang. >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Best Regards, >>>>>> Yang. >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>>>> For additional commands, e-mail: general-h...@incubator.apache.org >>>>> >>>>> >>>> >>>> -- >>>> Best Regards, >>>> Yang. >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>> For additional commands, e-mail: general-h...@incubator.apache.org >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
