> In LICENSE there’s no need to list hessian-lite license as it’s not been > bundled.
We have noticed this issue during vote in Dubbo Community and it will be removed in the next release. > A couple of other very minor issues exist: > - Netty has a (poor) NOTICE file [1] given a couple of files have been used > from that project the Dubbo NOTICE file needs to be updated. [2] > - Rather than including URL t license it best to use pointer to text files > contained within the release as content at URL change changes or no longer be > available. We will take a look at these LICENSE issues. > - several poms have "Copyright 1999-2011 Alibaba Group” in there headers > which should be removed. Ops, we thought it was all removed, will double check it later. > I also notice in the code of conduct that you put the contact address as > d...@dubbo.apache.org you may want to use the private list instead as this > may be a better place to discuss anything along those lines? I also think it should be priv...@dubbo.apache.org <mailto:priv...@dubbo.apache.org>. Best regards, Jun > On 16 Aug 2018, at 06:04, Justin Mclean <jus...@classsoftware.com> wrote: > > Hi, > > +1 binding > > I checked: > - incubating in name > - signatures and hashed all good > - DISCLAIMER exists > - LICENSE and NOTICE have minor issues (see below) > - No unexpected binary files > - All source files (other than a few pom files) have ASF headers > - Can compile from source > > In LICENSE there’s no need to list hessian-lite license as it’s not been > bundled. > > A couple of other very minor issues exist: > - Netty has a (poor) NOTICE file [1] given a couple of files have been used > from that project the Dubbo NOTICE file needs to be updated. [2] > - Rather than including URL t license it best to use pointer to text files > contained within the release as content at URL change changes or no longer be > available. > - several poms have "Copyright 1999-2011 Alibaba Group” in there headers > which should be removed. > > I also notice in the code of conduct that you put the contact address as > d...@dubbo.apache.org you may want to use the private list instead as this > may be a better place to discuss anything along those lines? > > Thanks, > Justin > > 1. https://github.com/netty/netty/blob/4.1/NOTICE.txt > 2. http://www.apache.org/dev/licensing-howto.html#mod-notice > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org >
