Hi Justin.
1. Sorry for 404 of how to build. It is caused by one of today's merge. Document location changed. Just after William checked our release. I should point it to our release TAG documents.[1] 2. The KEYS are used before and in ASF svn[2], and also in mail content, `Keys to verify the Release Candidate :` section. Is something wrong about this? I have checked locally again. .asc sign looks good. 3. > - LICENSE need work as you are not complying with the terms of the MIT license for iconfont as you need to include the full text of the license iconfont hasn't independent license, we have already discussed that in last vote. It belongs to antd project, which's license is already included in our distribution. Do you mean we need to add full text of the license to our source release too? 4. > - NOTICE doesn??t need to mention iconfont [1] MIT licensed items do not need to be added to NOTICE I will remove that. Both NOTICEs in source and distribution, right? [1] https://github.com/apache/incubator-skywalking/blob/v5.0.0-RC/docs/en/How-to-build.md [2] https://dist.apache.org/repos/dist/release/incubator/skywalking/KEYS ------------------ Sheng Wu Apache SkyWalking ------------------ Original ------------------ From: "justin"<jus...@classsoftware.com>; Date: Tue, Sep 4, 2018 05:38 PM To: "general"<general@incubator.apache.org>; Subject: Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC Hi, Sorry but it??s -1 (binding) due to LICENSE and NOTICE issues and instructions on how to build are missing. I checked: - incubating in name - signatures and hashes match (but needed to use KEY file) - DISCLAIMER exists - LICENSE need work as you are not complying with the terms of the MIT license for iconfont as you need to include the full text of the license - NOTICE doesn??t need to mention iconfont [1] MIT licensed items do not need to be added to NOTICE - No unexpected binary files - All source files have ASF headers - Can??t compile from source as instructions are missing It would be a good idea to publish your KEYS : gpg: Signature made Sat 1 Sep 00:25:10 2018 AEST gpg: using RSA key D360AB2AB20B28403270E2CBE8608938DB25E06B gpg: requesting key E8608938DB25E06B from hkps server hkps.pool.sks-keyservers.net sha512 apache-skywalking-apm-incubating-5.0.0-RC-src.tgz cat apache-skywalking-apm-incubating-5.0.0-RC-src.tgz.sha512 gpg: Can't check signature: No public key Also please include full build instruction in the release rather than pointing to a URL as the contents at that URL can change or move. (And in this case have) The build URL instruction in the README gives a 404: https://github.com/apache/incubator-skywalking/blob/master/docs/en/How-to-build.md Thanks, Justin 1. http://www.apache.org/dev/licensing-howto.html#permissive-deps --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
