Hi, +1 (binding) but there's a number of things to fix for the next release.
I checked: - incubating in name - DISCLAIMER exists - LICENSE and notice need more work (see below) - All ASF source files have ASF like headers (but not quite the correct text - see below) - No unexpected binary files LICENSE needs to list any licenses of bundled software it includes, currently it lists none. NOTICE should not list license information and is only reserved for certain things.(e.g relocated copyrights, content from other ASF notices files). Please speak to your mentors on how to assemble these files, [1] if it wasn’t your first release I would probably vote -1 on this. I would expect LICENSE to mention: - jquery-1.11.0.min.js - jquery-ui-1.9.2.js - underscore-1.2.2.js - jquery.dataTables-1.8.2.js - these 3 files [4][5][6] - these 2 files [7][8] - this file [9] I also a little concerned by this file [2] as it mentions thing that should not be in a source releases. (i.e. CDDL and EPL licensed things). Should this file [3] have an ASF header given it looks like public domain? either way it also should be in LICENSE. With headers I can see 4000+ instances of this: “The ASF licenses this file to you under the Apache License, Version 2.0 (the License”);" And 80 odd of: "The ASF licenses this file to You under the Apache License, Version 2.0 the “License”);” Neither of which isn’t quite right, ie You vs you and the missing bracket and missing quote. Probably a search replace went off-piste? The correct header has: "The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); “ I also note that a “mvn -DskipTests=true compile” will fail, but I was able to compile. Thanks, Justin 1. http://www.apache.org/dev/licensing-howto.html 2. apache-druid-0.13.0-incubating-src/examples/quickstart/tutorial/hadoop/docker/LICENSE 3. apache-druid-0.13.0-incubating-src/processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/Groupers.java 4. apache-druid-0.13.0-incubating-src/extendedset/src/main/java/org/apache/druid/extendedset/intset/AbstractIntSet.java 5. apache-druid-0.13.0-incubating-src/extendedset/src/main/java/org/apache/druid/extendedset/intset/ConciseSet.java 6. apache-druid-0.13.0-incubating-src/extendedset/src/main/java/org/apache/druid/extendedset/intset/IntSet.java 7. apache-druid-0.13.0-incubating-src/extendedset/src/main/java/org/apache/druid/extendedset/intset/ConciseSetUtils.java 8. apache-druid-0.13.0-incubating-src/extendedset/src/main/java/org/apache/druid/extendedset/utilities/IntList.java 9. apache-druid-0.13.0-incubating-src/server/src/main/resources/static/old-console/css/demo_table.css --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
