crap. Sorry, posts on wrong thread! > On Jun 30, 2019, at 12:13 AM, Joshua Poore <poor...@me.com.INVALID> wrote: > > Hi Justin, > > Thanks for the review! > > RE License appendix: > > Is it just the Copyright symbol that’s incorrect? Or do you see something > else. Just checking so that I know what to fix. Its the only thing I can see > as different from [1] > > reads as follwos: > > APPENDIX: How to apply the Apache License to your work. > > To apply the Apache License to your work, attach the following > boilerplate notice, with the fields enclosed by brackets "[]" > replaced with your own identifying information. (Don't include > the brackets!) The text should be enclosed in the appropriate > comment syntax for the file format. We also recommend that a > file or class name and description of purpose be included on the > same "printed page" as the copyright notice for easier > identification within third-party archives. > > © Copyright [yyyy] [name of copyright owner] > > Licensed under the Apache License, Version 2.0 (the "License"); > you may not use this file except in compliance with the License. > You may obtain a copy of the License at > > http://www.apache.org/licenses/LICENSE-2.0 > > Unless required by applicable law or agreed to in writing, software > distributed under the License is distributed on an "AS IS" BASIS, > WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > See the License for the specific language governing permissions and > limitations under the License. > > [1] https://www.apache.org/licenses/LICENSE-2.0 > <https://www.apache.org/licenses/LICENSE-2.0> > >> On Jun 29, 2019, at 8:53 PM, Justin Mclean <jus...@classsoftware.com> wrote: >> >> Hi, >> >> +1 (binding) >> >> I checked: >> - incubating in name >> - DISCLAIMER exists >> - LICENSE has some minor issues (see below) >> - NOTICE is fine >> - ASF file have ASF headers >> - No unexpected binary files >> - I didn’t compile as I’m on an unsupported platform >> >> LICENSE is missing: >> - UTF-8 library [1][2] >> - These files [3][4] copyright Facebook. The headers in this files may not >> be correct. >> - MIT licensed Sizzle from [6] >> >> The licensing information list in headers of [3][4] is confusing e.g Is it >> under an APLv2 license, or an AL or GPL license, or a BSD license? You might >> also want to read this JIRA [5] to double check that the version of rocksDB >> you are using is OK and not Category X. >> >> Thanks, >> Justin >> >> 1. ./be/src/gutil/utf/LICENSE >> 2. ./be/src/gutil/utf/rune.c >> 3. ./be/src/util/coding.cpp >> 4. ./be/src/util/coding.cpp >> 5. https://issues.apache.org/jira/browse/LEGAL-303 >> 6. /webroot/static/jquery.js >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >
--------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
