+1 binding
checked signature/checksum/disclaimer
license seems very thorough but two possible clarifications are suggested
below (*)
ran `make lib/libmxnet.so` successfully (opencv was listed as an optional
dependency but it seemed to be needed for this to work)
ran `make scalapkg` to generate Scala/Java jars (seemed to need to set
LD_LIBRARY_PATH for this to work)
ran `make ratcheck`
ran some Groovy/MXNet examples with the new jars - all worked
Cheers, Paul.
----
(*) I can't be sure without understanding the history but it seems like
there is possibly scope
to improve clarity for these two files for future releases:
10. ONNX Export module (python/mxnet/contrib/onnx/mx2onnx/LICENSE)
14. cmake/Modules/FindJeMalloc.cmake
It looks like both are based on some original but have been modified but
there are just two
different copyright notices with Apache License just pasted above the
previous one.
Hard to tell just from that what the history is. It might be clearer with
some additional wording, e.g.
----------.8-----------
Originally based on code with the following license:
Original license text
And has been modified by the Apache MXNet project. Modifications have the
following license:
Apache License text
----------.8-----------
But maybe there is further history behind those files, so hard to tell for
sure.
On Wed, Jul 10, 2019 at 7:34 PM Lai Wei <roywei...@gmail.com> wrote:
> Dear community,
>
> This is a call for a releasing Apache MXNet (incubating) 1.5.0, release
> candidate 2.
>
> Apache MXNet (incubating) community has voted and approved the release.
>
> Vote thread:
>
> https://lists.apache.org/thread.html/50fe473a3e03c891caccb8cae8e5195bb740a4758f7688790dff70df@%3Cdev.mxnet.apache.org%3E
>
> Result thread:
>
> https://lists.apache.org/thread.html/641cf0fddce623ff352ba9c7655938c0d16337bae4a8d290956ea130@%3Cdev.mxnet.apache.org%3E
>
> The source tarball, including signatures, digests, etc. can be found at:
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.5.0.rc2/
>
> The tag to be voted upon is 1.5.0.rc2:
> https://github.com/apache/incubator-mxnet/releases/tag/1.5.0.rc2
>
> The release hash is 75a9e18:
>
> https://github.com/apache/incubator-mxnet/commit/75a9e187d00a8b7ebc71412a02ed0e3ae489d91f
>
> Release artifacts are signed with the following key, KEYS file available:
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
>
> For information about the contents of this release, see:
> https://cwiki.apache.org/confluence/display/MXNET/1.5.0+Release+Notes
>
> The vote will be open for 72 hours.
>
> [ ] +1 release this package as ...
> [ ] +0 no opinion
> [ ] -1 do not release this package because...
>
>
> Best Regards
>
> Lai
>
