Thank you Justin. We will fix these. Are there any tools to verify the LICENSE/NOTICE files short of doing it manually?
dropwizard-hadoop-metrics2 has a NOTICE file [1]. Should we not include its contents? 1. https://github.com/joshelser/dropwizard-hadoop-metrics2/blob/master/NOTICE > On Aug 22, 2019, at 7:22 PM, Justin Mclean <jus...@classsoftware.com> wrote: > > Hi, > > -1 (binding) as the release is not in the correct place [1] and NOTICE is not > correct. [2][3] > > I checked: > - incubating in name > - DISCLAIMER exists > - LICENSE is OK > - NOTICE need more work and incorrectly includes unnecessary copyright > statements. > - all have source files ASF headers > - no unexpected binary files > - can compile from source > > You may want to consider using the work in progress disclaimer. [4] > > For the NOTICE and any ALv2 included code only needs to be listed if it has a > NOTICE file (these don’t) [2], MIT should not be listed. [3] > > Thanks, > Justin > > 1. https://incubator.apache.org/policy/incubation.html#releases > 2. http://www.apache.org/dev/licensing-howto.html#alv2-dep > 3. http://www.apache.org/dev/licensing-howto.html#mod-notice > 4. https://incubator.apache.org/policy/incubation.html#disclaimers > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
