+1 (binding) - Tarball name is correct (project, version, "incubating"). - NOTICE, LICENSE, DISCLAIMER-WIP files are present. - I didn't notice any LICENSE / NOTICE issues beyond what's already been discussed in the thread. - Verified .asc signatures and .sha512 checksums. - git.properties is present and correct. - Tarball contents match the expected git tag. - Was able to build from source and run tests on macOS 10.14.6.
One file is missing a copyright header: 1) ./hll/include/hll.private.hpp On Mon, Sep 9, 2019 at 12:05 PM Alexander Saydakov < sayda...@verizonmedia.com> wrote: > Dear IPMC and Community, > > This is a call for vote to release Apache DataSketches-cpp version > 1.0.0-incubating > > This is a C++ version of the DataSketches core library with Python > bindings. > > This is the first release of this component. > > We are not going to release any artifacts besides the source code. > > Results from the PPMC vote: > 3 votes were cast. All of the votes were (+1). One of the votes was from a > mentor. > > http://mail-archives.apache.org/mod_mbox/datasketches-dev/201909.mbox/thread > > The release candidate: > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/1.0.0-incubating-rc2/ > > Source repository: > https://github.com/apache/incubator-datasketches-cpp > > Git tag for this release: > > https://github.com/apache/incubator-datasketches-cpp/releases/tag/1.0.0-incubating-rc2 > > The artifact has been signed with key: > pub 4096R/A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) < > al...@apache.org> > Fingerprint=40A2 47F6 1E8C 6C75 678C 69C5 6848 6114 A8E8 B4E0 > > The public signing key can be found in the KEYS file: > https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS > > Changes from the RC1: > - added license to make files > - building and running unit tests does not require pybind11 (dependency for > Python bindings) > - better build instructions > > This library was intended to be header-only, but this goal was not fully > achieved yet with CPC sketch code. This work is in progress. > > Building and running unit tests requires CppUnit. > > Installing CppUnit on OSX: brew install cppunit > Installing CppUnit on RHEL: yum install cppunit-devel > > There are currently two ways of building: using existing make files and > generating make files using cmake. Exsisting make files might not work on > all platforms or with all C++ compilers. Generating make files using cmake > should solve this problem, but it currently requires cmake version 3.12.0 > or higher that might not be readily available as a package on all > platforms. > > Installing the latest cmake on OSX: brew install cmake > > Building and running unit tests using existing make files: > $ make > $ make test > > Building and running unit tests using cmake: > $ mkdir build > $ cd build > $ cmake .. > $ make > $ make test > > Building Python bindings requires cmake 3.12 or higher and pybind11. > Please see the following document for details: > > https://github.com/apache/incubator-datasketches-cpp/blob/1.0.0-incubating-rc2/python/README.md > > This is the second stage vote. The vote will remain open for at least 72 > hours and at least 3 (+1) IPMC votes or a majority of (+1) are acquired. > > Please vote accordingly: > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > Thanks, > Alexander Saydakov > al...@apache.org >
