The part that Justin's probably referring to is this line: Copyright 2018- Verizon Media
Copyright should have stopped claiming by Verizon Media when the code was donated, so listing an end date there would be preferred (though unless the project was called DataSketches at Yahoo/Verizon Media those lines are incorrect). John On Sat, May 2, 2020 at 12:44 PM leerho <lee...@gmail.com> wrote: > Hi Justin, > Thank you for your vote: > > NOTICE is a little odd with Verizon Media copyright line > > > What do you find "odd"? > > The are some .bin files in the test resources that like like they may be > > compiled code. Is there a way to generate these from source code? > > > Those bin files are not compiled source code but are representative binary > output images of sketch data structures that fall into one of 2 cases: > > - Sketch images produced by C++. This allows us to validate > cross-language binary compatibility. > - Sketch images produced by earlier versions of the source code. This > allows to to validate forward compatibility. > > We have certainly talked about ways to eliminate these binaries, but have > yet to come up with a solution that would be efficient and effective. > > Lee. > > On Fri, May 1, 2020 at 11:30 PM Justin Mclean <jus...@classsoftware.com> > wrote: > > > Hi, > > > > +1 (binding) > > > > I checked: > > - incubating in name > > - signatures and hashes are fine > > - disclaimer exists > > - LICENSE is fine > > - NOTICE is a little odd with Verizon Media copyright line > > - The are some .bin files in the test resources that like like they may > be > > compiled code. Is there a way to generate these from source code? > > - All ASF file have ASF headers > > - Can compile from source > > > > Thanks, > > Justin > > > > >
