I released rc2 to remove the node_modules dir completely. Please vote on the RC2 and this VOTE is closed now.
https://lists.apache.org/thread.html/r6fddf4b35d8da90161c679ed9fc902f504ff2780d8e39e53bd677bab%40%3Cgeneral.incubator.apache.org%3E On 2020/09/02 00:49:20, Felix Cheung <felixche...@apache.org> wrote: > It’s a bit strange under node_modules. > > - incubating in name > - signature and hash fine > - DISCLAIMER is fine > - LICENSE and NOTICE are fine > - Unexpected binary files > > Several strange files are in the source tarball > /pinot-controller/src/main/resources/node_modules/fsevents/build/Release/obj.target/fse/fsevents.o > /pinot-controller/src/main/resources/node_modules/core-util-is/float.patch > > about 10 tgz like > /pinot-controller/src/main/resources/node_modules/@webassemblyjs/wasm-parser/webassemblyjs-wasm-parser-1.7.10.tgz > > - Source files have ASF headers > > Generally, looks like a lot of files under node_modules > > - compile from source - didn't build > > > On Tue, Sep 1, 2020 at 1:43 PM Jialiang Li <j...@apache.org> wrote: > > > +1 > > > > > > > > On 2020/09/01 00:54:44, Ting Chen <tingc...@apache.org> wrote: > > > > > Hi all, > > > > > > > > > > This is a call for a vote to release Apache Pinot (incubating) version > > > > > 0.5.0. > > > > > > > > > > Apache Pinot (incubating) is a distributed columnar storage engine that > > can > > > > > ingest data in realtime and serve analytical queries at low latency. > > > > > > > > > > The Pinot community has voted and approved this release. > > > > > > > > > > Vote thread: > > > > > > > https://lists.apache.org/thread.html/rd16efae6e7f5f89d0702f3849b1a2e61c1ff25619d62ecf2807a2140%40%3Cdev.pinot.apache.org%3E > > > > > > > > > > Result thread: > > > > > > > https://lists.apache.org/thread.html/rc06b378d62134372ea5091427a0e5002a70a3dd0df630c4c3586a2a4%40%3Cdev.pinot.apache.org%3E > > > > > > > > > > The release candidate: > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/pinot/apache-pinot-incubating-0.5.0-rc1 > > > > > > > > > > Git tag for this release: > > > > > https://github.com/apache/incubator-pinot/tree/release-0.5.0-rc1 > > > > > > > > > > Git hash for this release: > > > > > 3c40ea207f84a36aa60bc2ff9987431d2d746222 > > > > > > > > > > The artifacts have been signed with a key: C650A5210408F8F4, which can be > > > > > found in the following KEYS file. > > > > > https://dist.apache.org/repos/dist/release/incubator/pinot/KEYS > > > > > > > > > > Release notes: > > > > > https://github.com/apache/incubator-pinot/releases/tag/release-0.5.0-rc1 > > > > > > > > > > Staging repository: > > > > > https://repository.apache.org/content/repositories/orgapachepinot-1015 > > > > > > > > > > Documentation on verifying a release candidate: > > > > > > > https://cwiki.apache.org/confluence/display/PINOT/Validating+a+release+candidate > > > > > > > > > > > > > > > *Special notes for verification: During this step "diff -r > > > > > apache-pinot-incubating-${VERSION}-src pinot-git-src", due to Cluster > > > > > Manager UI & Query Console UI revamp (#5684), you might see the extra > > lines > > > > > below. It is fine because they are generated code for the revamped > > > > > controller UI.* > > > > > > > > > > *Only in > > > > > apache-pinot-incubating-0.5.0-src/pinot-controller/src/main/resources: > > dist* > > > > > *Only in > > > > > apache-pinot-incubating-0.5.0-src/pinot-controller/src/main/resources: > > > > > node_modules* > > > > > *Only in > > > > > apache-pinot-incubating-0.5.0-src/pinot-controller/src/main/resources: > > > > > package-lock.json* > > > > > > > > > > > > > > > The vote will be open for at least 72 hours or until a necessary number > > of > > > > > votes are reached. > > > > > > > > > > Please vote accordingly, > > > > > > > > > > [ ] +1 approve > > > > > [ ] +0 no opinion > > > > > [ ] -1 disapprove with the reason > > > > > > > > > > Thanks, > > > > > Apache Pinot (incubating) team > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
