HI, -1 (binding) due to license and notice issues
I checked: - incubating in name - LICENSE has issues (see below) - NOTICE has wrong year - DISCLAIMER exists (not WIP one) - no unexpected binary files - ASF files have ASF headers I’m a little confused by the LICENSE file. First off it uses URLs to link to the LICENSE text, the full license text often needs to be included as part of the license conditions (from ALv2, MIT and BSD style licenses so need to be included in the releases. While the URL are useful they can break over time or worse the license change, you should point to the license file in the licenses directory. Also part of the BSD and MIT licences include a copyright line and this will vary with each bit of included code. JSXTransformer is listed under the Apache 2.0, MIT, BSD 2 clause and BSD 3 clause licenses. It may be that this files include 3rd party code under different licenses or the file itself is under multiple licenses. If it was under multiple licenses you would generally select which one you want to use. If not then each of those pieces of 3rd party code is likely to have its own name and copyright holder (for MIT and BSD licenses) which need to be included or pointed to by the LICENSE file. LICENSE is also missing the license for the trykker font and may be missing other things. Thanks, Justin --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
