+1 with caveats Checked hashes and signatures DISCLAIMER exists NOTICE seems okay but possibly missing some elements (1) LICENSE seems okay but possibly missing some elements (1) "mvn clean verify" passes on Ubuntu "mvn clean verify" failed for me on Windows but possibly my environment (2) "mvn apache-rat:rat" passes incubating in name no unexpected binary files I ran my groovy-data-science example. Worked after adjusting for a binary breaking change. (3)
Cheers, Paul. ================== (1) some of the data files seem to be missing appropriate attribution I checked only src/main/resources/moby and src/main/resources/badfilter, perhaps worth checking all folders under resources. moby files seem to be "Released by Grady Ward into the public domain[1][2]". While this would allow relicensing under Apache, it isn't clear that is what you are intending. I suspect just a reference in the LICENSE file is intended. swear_words.txt says licensed under Apache but seems to come from a third-party site which seems to suggest "copyright Ryan Jones" or "Copyright All Slang Network" is needed in NOTICE file and it might be worth querying the author what license is applicable. From the website, it seems public domain but not explicitly stated? Or if you have obtained from another source, they may have already established licensing. In any case, some mention of licensing is needed. [1] https://en.wikipedia.org/wiki/Moby_Project [2] http://cs.sru.edu/~ddailey/whence.html (2) Windows errors: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test (integration-tests) on project nlpcraft: There are test failures. [ERROR] [ERROR] Please refer to D:\tmp\nlpcraft\073\apache-nlpcraft\nlpcraft\target\surefire-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. [ERROR] The forked VM terminated without properly saying goodbye. VM crash or System.exit called? [ERROR] Command was cmd.exe /X /C "C:\Progra~1\AdoptOpenJDK\jdk-11.0.8.10-hotspot\bin\java -jar "C:\Users\Paul King\AppData\Local\Temp\surefire7851445059229675487\surefirebooter6212500639838130057.jar" "C:\Users\Paul King\AppData\Local\Temp\surefire7851445059229675487" 2021-01-18T18-48-51_629-jvmRun1 surefire17512347805813647919tmp surefire_0900453059839016198tmp" [ERROR] Process Exit Code: 0 [ERROR] Crashed tests: [ERROR] org.apache.nlpcraft.server.rest.NCRestAskSpec [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called? [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test (integration-tests) on project nlpcraft: There are test failures. [ERROR] [ERROR] Please refer to D:\tmp\nlpcraft\073\apache-nlpcraft\nlpcraft\target\surefire-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. [ERROR] The forked VM terminated without properly saying goodbye. VM crash or System.exit called? [ERROR] Command was cmd.exe /X /C "C:\Progra~1\AdoptOpenJDK\jdk-11.0.8.10-hotspot\bin\java -jar "C:\Users\Paul King\AppData\Local\Temp\surefire3495260889293679007\surefirebooter12040527775344534193.jar" "C:\Users\Paul King\AppData\Local\Temp\surefire3495260889293679007" 2021-01-18T18-54-27_237-jvmRun1 surefire6023894785853744471tmp surefire_02137409296786047525tmp" [ERROR] Process Exit Code: 0 [ERROR] Crashed tests: [ERROR] org.apache.nlpcraft.probe.mgrs.nlp.enrichers.sort.NCEnricherSortSpec [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called? (3) Binary breaking change: https://github.com/apache/incubator-nlpcraft/commit/6ee9a3808 I was using NCEmbeddedProbe#start(Class) but now need to pass a null configFile param plus Collection<String>. I am unsure whether you are trying to honor semantic versioning at this point, so might be okay. On Thu, Jan 14, 2021 at 8:28 AM Aaron Radzinski <aradzin...@apache.org> wrote: > Hello all, > This is a call for a vote to release Apache NLPCraft (incubating) > version 0.7.3. Apache NLPCraft is a library for adding a natural language > interface to any application. > > The Apache NLPCraft community has voted on and approved a proposal to > release Apache NLPCraft (Incubating) version 0.7.3. We would like to > request the Incubator PMC members review and vote on this incubator > release. > > Release information: > 1. PPMC vote result thread: https://mail-archives.apache.org/mod_mbox/ > nlpcraft > -dev/202011.mbox/< > cacwejt_bjzw7vcdayws_pyywhfpaasctujyo-k4d2k8ydx6...@mail.gmail.com> > <https://mail-archives.apache.org/mod_mbox/nlpcraft-dev/202101.mbox/ > <CACwEJt9xJ152nrUHhfOubOfYkexyGMxym_HYQf%2BKUR69XmboRw%40mail.gmail.com>> > 2. Release location: > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.3/ > 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.3 > 4. JIRA issues fixed in release: > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349299 > 5. KEYS file: > https://dist.apache.org/repos/dist/release/incubator/nlpcraft > /KEYS > > The vote will be open for at least 72 hours or until a necessary number > of votes are reached. > > Please vote accordingly: > +1 approve > +0 no opinion > -1 disapprove with the reason > > Thank you, > On behalf of NLPCraft community >
