Hi Justin 1. [1][2] [3] code under /be/src/gutil/ is come from Apache Kudu https://github.com/apache/kudu/blob/master/src/kudu/gutil/arm_instruction_set_select.h, those file are also existed in impala's code 2. [6] [7] means that our previous version had dependencies under a GPL license, but it has been removed in the new version. if user want to use it, need to solve it by themselves 3. [4] [5] The license of this file is indeed unknown. Since I cannot contact the submitter of these files at present, I cannot determine the license, but we will clarify the licenses of these files in the next version and remove the files that do not comply with the license. Can this issue be skipped for the 0.14 release?
Justin Mclean <jus...@classsoftware.com> 于2021年4月12日周一 下午4:52写道： > Hi, > > -1 (binding) due to LICENSE and NOTICE issues, possible GPL dependancy > issues, and possible font licensing issues. There might be an explanation > for all of these, if so I’ll consider changing my vote. > > I checked: > - incubating in name > - checksums are fine > - LICENSE seems OK but it’s not possible to check as it unknown where some > of the 3rd party code is from e.g. code under /be/src/gutil/ is copyright > google, the license is not mentioned in the header. For example this file > [2] a quick search shows this file [3] which has a difference license. > - This font files are not mentioned [4][5] and are of unknown license. It > a god idea to mention where the dependancy come from and the version of the > software. > - Things are mentioned in LICENSE but are not in the source release e.g. > webroot/static/jquery.dataTables.js or > webroot/be/bootstrap/css/bootstrap.min.css > - NOTICE is not correct. The notice file is not for listing > included/bundled 3rd party software. The notice file should include any > relocated copyright files, (usually from software grants) and parts of > notice files from Apache licensed bundled software. [1] > - These files [6][7] mention that same 3rd party dependancies are under a > GPL license, is this still correct? > - No unexpected binary files, except possibly the font files > - I didn’t try to comply from source > > Thanks, > Justin > > 1. https://infra.apache.org/licensing-howto.html#mod-notice > 2. ./be/src/gutil/arm_instruction_set_select.h > 3. > https://github.com/crosswalk-project/chromium-crosswalk/blob/master/third_party/tcmalloc/chromium/src/base/arm_instruction_set_select.h > 4. ./ui/public/fonts/iconfont/iconfont.* > 5. ./ui/public/fonts/fonts/icomoon.* > 6. ./docs/zh-CN/installing/compilation.md > 7 ./docs/en/installing/compilation.md > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
